1. 02 Sep, 2015 1 commit
    • Jakub Adam's avatar
      ms-turn: don't wait for a reply to STUN_SEND request · ab4ced5a
      Jakub Adam authored
      As per [MS-TURN] Section 2.2.1, TURN message type 0x0104 "Send request
      response" isn't supported and the TURN server MUST NOT send them. Thus,
      libnice should not remember Send requests in agent->sent_ids because
      without replies coming, the number of allowed pending transaction gets
      quickly exhausted, causing our data packets to be dropped until a
      request timeout frees some space in the queue.
      
      This behavior resulted in choppy reception of our audio on a Lync client
      when connected via Lync Edge (TURN) Server.
      
      Maniphest Tasks: T126
      
      Reviewers: pwithnall
      
      Projects: #libnice
      
      Reviewed By: pwithnall
      
      Subscribers: pwithnall
      
      Differential Revision: https://phabricator.freedesktop.org/D223
      ab4ced5a
  2. 29 Aug, 2015 4 commits
  3. 19 Aug, 2015 5 commits
  4. 18 Aug, 2015 4 commits
  5. 03 Jul, 2015 1 commit
  6. 01 Jul, 2015 1 commit
  7. 30 Jun, 2015 1 commit
  8. 24 Jun, 2015 2 commits
  9. 01 Jun, 2015 1 commit
  10. 08 May, 2015 1 commit
    • Philip Withnall's avatar
      build: Auto-generate win32 .def file from libnice.sym · d3a7b315
      Philip Withnall authored
      We’ve neglected to manually update this file once too often — it’s been
      out of date for important new symbols (for example,
      nice_agent_get_io_stream()) since at least 0.1.11.
      
      Since the format is a simple extension of libnice.sym, we might as well
      automatically generate it at dist time.
      d3a7b315
  11. 05 May, 2015 3 commits
    • Youness Alaoui's avatar
      Removing no-op assignment · 6a8c6321
      Youness Alaoui authored
      6a8c6321
    • Youness Alaoui's avatar
      Do not compare scope for IPv6 address when scope is 0 · 91a7b932
      Youness Alaoui authored
      This caused issues with thinking local host candidates were peer-reflexive
      candidates because the nice_address_equal would fail since the scope
      would be 6 (or some other value) but locally created NiceAddress from
      a stun response would have the scope set to 0.
      We ignore the scope when comparing ipv6 candidates when scope is 0
      to avoid these kinds of issues.
      Thanks to ikonst_ for finding these issues
      91a7b932
    • Youness Alaoui's avatar
      Do not update a remote candidate's type · 93862c1e
      Youness Alaoui authored
      When adding a remote candidate, if it's the same ip:port, we should
      also check its type, otherwise it's a new candidate. We can't allow
      a candidate type to be updated. This caused issues to ikonst_ on IRC
      where for some reason a host candidate appeared as both host and prflx
      and the update caused a remote host candidate to be updated to prflx
      causing a crash when the sockptr was being accessed.
      93862c1e
  12. 03 May, 2015 1 commit
  13. 28 Apr, 2015 3 commits
  14. 24 Apr, 2015 3 commits
  15. 23 Apr, 2015 6 commits
  16. 22 Apr, 2015 1 commit
  17. 20 Apr, 2015 2 commits