- 09 Oct, 2014 17 commits
-
-
Olivier Crête authored
There is no reason to only allow modifying it in the new().
-
Olivier Crête authored
The newer RFC 6298 recommends 1 second instead of 3.
-
Olivier Crête authored
This is how it is specified in RFC 5245 section 16
-
Olivier Crête authored
-
Olivier Crête authored
Also don't try to re-add pairs that already have been added
-
Olivier Crête authored
-
Olivier Crête authored
The rest of the list is sorted, but this was just appended, making it likely to be dropped if the list grows too long.
-
Olivier Crête authored
priv_limit_conn_check_list_size() would remove elemtns from the conncheck_list while the calling functions were iterating it. Now instead just mark them as cancelled. Then later, at the outer function, free all cancelled elements to prevent the list from growing out of bounds.
-
Olivier Crête authored
Clean up the UPnP mappings of each stream when closing it
-
Olivier Crête authored
This would cause mappings to be dropped on every new gather, which is bad! Instead, keep the same one with the mappings, and just drop the timer to ignore new discovered mappings afterwards.
-
Olivier Crête authored
-
Olivier Crête authored
This is to ensure that the result of the new negotiation will always have priority.
-
Philip Withnall authored
To try and avoid NULL NiceCandidates entering our internal state.
-
Philip Withnall authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
Don't change the state if no pair is selected. Otherwise we get a component that claims to be CONNECTED but has no selected pair. Also, set the selected pair before announcing the state change.
-
- 08 Oct, 2014 1 commit
-
-
Olivier Crête authored
It doesn't make sense to tell applications to include <agent.h>, including <nice/agent.h> is much safer. So tell the applications to use the includedir directly.
-
- 26 Sep, 2014 3 commits
-
-
Philip Withnall authored
GIOStream and nice_agent_remove_stream() interact slightly subtly when closing down the stream. See: https://bugzilla.gnome.org/show_bug.cgi?id=735754
-
Philip Withnall authored
-
Philip Withnall authored
This makes helgrind slightly happier.
-
- 25 Sep, 2014 8 commits
-
-
Philip Withnall authored
-
Philip Withnall authored
This could result in leaking the stream’s un-closed state otherwise, in any case where a NiceAgent is finalised without nice_agent_remove_stream() being called on all its streams.
-
Philip Withnall authored
To be used with `make check-valgrind`.
-
Philip Withnall authored
The theory being that if we can get check-valgrind to pass, we could acutally use it to find more memory leaks and other errors in the agent.
-
Philip Withnall authored
This should fix a crash, as detected by Valgrind: ==28354== Invalid read of size 2 ==28354== at 0x4C2B5B0: memcpy@@GLIBC_2.14 (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==28354== by 0x50C17E2: stun_message_id (stunmessage.c:658) ==28354== by 0x509E4E7: candidate_check_pair_fail (conncheck.c:254) ==28354== by 0x50A4EDB: conn_check_prune_socket (conncheck.c:3145) ==28354== by 0x509B6F8: component_io_cb (agent.c:3951)
-
Philip Withnall authored
The GSource holds a reference to the GCancellable, so needs to be explicitly removed from the GMainContext when it’s finised with.
-
Philip Withnall authored
-
Philip Withnall authored
There is no need for this to be heap-allocated.
-
- 24 Sep, 2014 1 commit
-
-
Olivier Crête authored
-
- 23 Sep, 2014 5 commits
-
-
Philip Withnall authored
-
Philip Withnall authored
Stack variables can be initialised to zero by explicit assignment. This introduces no functional changes.
-
Philip Withnall authored
This introduces no functional changes.
-
Philip Withnall authored
To try and avoid NULL NiceCandidates entering our internal state.
-
Philip Withnall authored
To try and avoid NULL NiceCandidates entering our internal state.
-
- 22 Sep, 2014 5 commits
-
-
Olivier Crête authored
Fix regressions introduced by the following patch: Clear existing GSource timeouts before adding new ones
-
Philip Withnall authored
Rather than passing them through to the application. Invalid STUN packets are still passed through, but it causes unnecessary noise and corruption for higher-level applications to receive STUN packets they weren’t expecting. This is permitted by RFC 5389, §7.3.0: If any errors are detected, the message is silently discarded. In the case when STUN is being multiplexed with another protocol, an error may indicate that this is not really a STUN message; in this case, the agent should try to parse the message as a different protocol. where I interpret ‘error’ to mean ‘validation error’ rather than (e.g.) ‘unrecognised attribute’ or ‘unmatched response’ where the STUN packet is otherwise perfectly formed.
-
Philip Withnall authored
If a NiceSocket is destroyed, various pointers are currently left dangling to it in the conncheck state. These can cause crashes if (for example) a CandidateCheckPair with such a dangling pointer is then used; the GSocket methods will fail. Fix this by explicitly removing the socket and all NiceCandidates which wrap it from various areas of the state.
-
Philip Withnall authored
This introduces no functional changes.
-
Philip Withnall authored
-