- 03 May, 2022 2 commits
-
-
Olivier Crête authored
-
Philippe Normand authored
Can be useful to know which TURN server is being used as relay server for a given candidate.
-
- 20 Apr, 2022 1 commit
-
-
Olivier Crête authored
It's possible that the callback will be called synchronously during the close function, in this case, we need to be ready to the last reference to the agent to be dropped in this callback. This fix was suggested by Fabrice Bellet Fixes #153
-
- 06 Apr, 2022 1 commit
-
-
Johan Sternerup authored
If we have gathered a host IP-address that is link-local we should never try to use it for anything else than trying to match it with another link-local address. Some routers seem to have problems with traffic from link-local addresses destined at external IP-addresses. By definition link-local addresses should stay local so there's no reason to access STUN/TURN from it or try to form a candidate with another address that is not link-local.
-
- 21 Mar, 2022 2 commits
-
-
Nirbheek Chauhan authored
../agent/discovery.c: In function ‘on_refresh_remove_timeout’: ../agent/discovery.c:203:13: warning: Not available before 2.60 203 | G_GNUC_FALLTHROUGH; | ^~~~~~~~~~~~~ ../agent/conncheck.c: In function ‘priv_turn_allocate_refresh_retransmissions_tick_agent_locked’: ../agent/conncheck.c:1656:13: warning: Not available before 2.60 1656 | G_GNUC_FALLTHROUGH; | ^~~~~~~~~~~~~ The comment /* fall through */ is enough to cause GCC and Clang to not emit the implicit-fallthrough warning.
-
Nirbheek Chauhan authored
This was probably added by mistake.
-
- 26 Jan, 2022 1 commit
-
-
Olivier Crête authored
This should fix builds on platforms openssl
-
- 26 Nov, 2021 4 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
Fixes issue found by Coverity
-
Olivier Crête authored
In one case, the message pointer gets replaced by the rfc4571_message one, so it wasn't getting cleared as expected.
-
Guillaume Desmottes authored
It's very tricky and unintuitive to have webrtcbin not sending data because of the segment. Fix https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/907
-
- 22 Nov, 2021 12 commits
-
-
Ole André Vadla Ravnås authored
Busy-looping is not a good idea, especially not when run under Valgrind, where such a thread may result in well-behaved threads running thousands of times slower. While passing --fair-sched=yes to Valgrind avoids the issue, it's still better to make our busy-looping less aggressive.
-
Ole André Vadla Ravnås authored
This was caught by tests randomly failing (timing out).
-
Ole André Vadla Ravnås authored
-
Ole André Vadla Ravnås authored
In case close() is called more than once.
-
Ole André Vadla Ravnås authored
-
Ole André Vadla Ravnås authored
-
Ole André Vadla Ravnås authored
-
Ole André Vadla Ravnås authored
We cannot assume that the message will be completely filled even in reliable mode.
-
Ole André Vadla Ravnås authored
Cannot pass g_main_loop_quit as the GSourceFunc as its return type is void.
-
Ole André Vadla Ravnås authored
Due to off-by-one errors. Since the code added above now handles what this code tried to handle, we can go ahead and remove it.
-
Ole André Vadla Ravnås authored
-
Fabrice Bellet authored
With this patch we ensure that local socket errors during connection establishment are properly transmitted to the connection check layer, so the related pair can be put in state failed when needed. The local socket errors we are interested in, are those occuring when the local source address cannot be bound anymore, because the underlying interface vanished for example. In particular, we don't ignore errors coming from g_socket_bind() with tcp active sockets, that perform a bind to *whatever* local address is available, in case it cannot bind to the specified address. This behaviour was demonstrated with the test-tcp example, that tried to bind to the IPv4 loopback address on a socket initially created for the IPv6 loopback.
-
- 15 Nov, 2021 1 commit
-
-
Nirbheek Chauhan authored
Meson picks up the includedirs from the library target that it is building the pkgconfig file for. Since libnice's headers are split into the nice/ and agent/ subdirs, we need to add agent/ to include_directories: so that it's automatically added to the uninstalled pkgconfig file by Meson.
-
- 03 Nov, 2021 1 commit
-
-
Ole André Vadla Ravnås authored
E.g. if the server address is IPv6 but the local system cannot reach it, so connect() fails right away.
-
- 02 Nov, 2021 8 commits
-
-
Fabrice Bellet authored
The patch invokes the conncheck timer creation where it makes most sense: when a new pair is inserted in the conncheck list, and when a pair is added to the triggered check list (because the conncheck scheduler works on these two lists).
-
Olivier Crête authored
This should make it possible to use OpenSSL or GnuTLS also on Windows if required.
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
Remove duplicated calls to dependency() so we can have fallback in all cases.
-
Olivier Crête authored
This is a fix over the recent fix in commit 574f44b4
-
Olivier Crête authored
-
Olivier Crête authored
-
- 01 Nov, 2021 4 commits
-
-
Fabrice Bellet authored
This patch ensures that related succeeded-discovered pairs change to state failed simultaneously, to avoid leaving dangling pointers if one is freeed while the other is still in the conncheck list. Such transition is very rare, and only occurs in regular nomination mode, when the network conditions change between the time the pair is initially discovered and the time it is rechecked with the use-candidate flag.
-
Xavier Claessens authored
In that case crypto_dep is a list and we can't call .found() method.
-
Juan Navarro authored
Instead of having 3 independent implementations, make the simpler versions delegate into the full one. The simplest constructor needs to pass "no option", for which no constant exists in the NiceAgentOption enum. Thus the new NICE_AGENT_OPTION_NONE constant is added to reflect this possibility.
-
Ole André Vadla Ravnås authored
As we only need a few primitives there isn't much OS-specific code needed, and for applications that don't already depend on OpenSSL or GnuTLS it simplifies the build process quite a lot. Note that we use the vintage WinCrypt APIs as the Cryptography Next Generation APIs are only available on Vista and newer.
-
- 04 Oct, 2021 1 commit
-
-
Fabrice Bellet authored
The stun agent may contain references to the password previously stored in some remote candidates, freeed by nice_component_restart(), that were used by keep-alive stun requests. These stun replies may arrive later after ice has been restarted. Since the remote candidates are freeed when ice is restarted, the stun agent must be reset to get rid of these related references.
-
- 01 Oct, 2021 2 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-