- 05 Nov, 2014 1 commit
-
-
Nicolas Dufresne authored
Note that this only works for 1.0 plugin. https://bugs.freedesktop.org/show_bug.cgi?id=85929
-
- 30 Oct, 2014 2 commits
-
-
Philip Withnall authored
wrt the ML thread: http://lists.freedesktop.org/archives/nice/2014-October/000981.html
-
Philip Withnall authored
This tries to mitigate the race condition between finishing the TCP FIN handshake and closing the underlying sockets, but it’s impossible to mitigate properly without API changes. See the comment.
-
- 27 Oct, 2014 1 commit
-
-
Curieux Tres authored
The symbol is not exported, but nevertheless leaks in the static version of libnice, due to limitations on symbol visibilities with static libraries. OpenSSL has a symbol named RAND_bytes(), which ours clashes with if the two are linked together statically. Avoid this by prefixing ours with ‘nice_’.
-
- 09 Oct, 2014 27 commits
-
-
Youness Alaoui authored
-
Youness Alaoui authored
All discovered peer-reflexive candidates should be added internally in conncheck.c and should have the sockptr set. We ignore any prflx candidates added by an external application because their NULL sockptr could cause a crash in conn_check_send().
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
It prevent the GError from happening
-
Olivier Crête authored
-
Olivier Crête authored
We attempted to not pass through some packets that looked like valid STUN but were ot acceptable to us, but that dropped some application packets.
-
Olivier Crête authored
If the stream was ever gathering and a new relay has been set, then re-emit the candidate=gathering-done signal
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
There is no reason to only allow modifying it in the new().
-
Olivier Crête authored
The newer RFC 6298 recommends 1 second instead of 3.
-
Olivier Crête authored
This is how it is specified in RFC 5245 section 16
-
Olivier Crête authored
-
Olivier Crête authored
Also don't try to re-add pairs that already have been added
-
Olivier Crête authored
-
Olivier Crête authored
The rest of the list is sorted, but this was just appended, making it likely to be dropped if the list grows too long.
-
Olivier Crête authored
priv_limit_conn_check_list_size() would remove elemtns from the conncheck_list while the calling functions were iterating it. Now instead just mark them as cancelled. Then later, at the outer function, free all cancelled elements to prevent the list from growing out of bounds.
-
Olivier Crête authored
Clean up the UPnP mappings of each stream when closing it
-
Olivier Crête authored
This would cause mappings to be dropped on every new gather, which is bad! Instead, keep the same one with the mappings, and just drop the timer to ignore new discovered mappings afterwards.
-
Olivier Crête authored
-
Olivier Crête authored
This is to ensure that the result of the new negotiation will always have priority.
-
Philip Withnall authored
To try and avoid NULL NiceCandidates entering our internal state.
-
Philip Withnall authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
Don't change the state if no pair is selected. Otherwise we get a component that claims to be CONNECTED but has no selected pair. Also, set the selected pair before announcing the state change.
-
- 08 Oct, 2014 1 commit
-
-
Olivier Crête authored
It doesn't make sense to tell applications to include <agent.h>, including <nice/agent.h> is much safer. So tell the applications to use the includedir directly.
-
- 26 Sep, 2014 3 commits
-
-
Philip Withnall authored
GIOStream and nice_agent_remove_stream() interact slightly subtly when closing down the stream. See: https://bugzilla.gnome.org/show_bug.cgi?id=735754
-
Philip Withnall authored
-
Philip Withnall authored
This makes helgrind slightly happier.
-
- 25 Sep, 2014 5 commits
-
-
Philip Withnall authored
-
Philip Withnall authored
This could result in leaking the stream’s un-closed state otherwise, in any case where a NiceAgent is finalised without nice_agent_remove_stream() being called on all its streams.
-
Philip Withnall authored
To be used with `make check-valgrind`.
-
Philip Withnall authored
The theory being that if we can get check-valgrind to pass, we could acutally use it to find more memory leaks and other errors in the agent.
-
Philip Withnall authored
This should fix a crash, as detected by Valgrind: ==28354== Invalid read of size 2 ==28354== at 0x4C2B5B0: memcpy@@GLIBC_2.14 (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==28354== by 0x50C17E2: stun_message_id (stunmessage.c:658) ==28354== by 0x509E4E7: candidate_check_pair_fail (conncheck.c:254) ==28354== by 0x50A4EDB: conn_check_prune_socket (conncheck.c:3145) ==28354== by 0x509B6F8: component_io_cb (agent.c:3951)
-