- 12 Jun, 2017 3 commits
-
-
Fabrice Bellet authored
This patch makes the code compliant with ICE RFC, 7.2.1.3 "Learning Peer Reflexive Candidates" and 7.1.3.2.1 "Discovering Peer Reflexive Candidates", where discovered candidates do not cause the creation of new pairs to be checked. Differential Revision: https://phabricator.freedesktop.org/D805
-
Fabrice Bellet authored
This modifies commit 8f1f615e. It is better focused to update the selected pair just after its nominated flag has been set. We also keep the code homogeneous with other places, where the call to priv_update_selected_pair() immediately follows the setting of pair->nominated. Moreover in priv_update_check_list_state_for_ready(), we would call priv_update_selected_pair() more times that necessary when iterating on all nominated pairs. Differential Revision: https://phabricator.freedesktop.org/D1125
-
Fabrice Bellet authored
Three STUN binding request properties should be customisable. RFC 5245 describes the retransmission timer of the STUN transaction 'RTO', and RFC 5389 describes the number of retransmissions to send until a response is received 'Rc'. The third property is the 'RTO' when a reliable connection is used. RFC 5389 introduces a supplementary property 'Rm' as a multiplier used to compute the final timeout RTO * Rm. However, this property is not added in libnice, because this would require breaking the public API for STUN. Currently, our STUN implementation hardcodes a division by two for this final timeout. Differential Revision: https://phabricator.freedesktop.org/D1109
-
- 08 Jun, 2017 2 commits
-
-
Olivier Crête authored
Reported by Capricornus (zhushengliang) https://phabricator.freedesktop.org/T7763
-
Fabrice Bellet authored
Some interfaces, like the one managed by libvirtd to provide a network bridge to locally hosted virtual machines, can be completely ignored when gathering ICE candidates. The motivation for adding this possibility is that, ignoring them doesn't remove capabilities, and improves the overall speed of the connection check method, by reducing the number of pairs to be tested. This patch adds the possibility to define such interfaces in the configuration script. Differential Revision: https://phabricator.freedesktop.org/D948
-
- 01 May, 2017 1 commit
-
-
Philip Withnall authored
There’s no point in installing them; their benefit is in providing example code to developers. Debian doesn’t package them; Fedora packages them in a separate subpackage which will have to disappear. Signed-off-by:
Philip Withnall <withnall@endlessm.com> Reviewed-by:
Olivier Crête <olivier.crete@collabora.com> Differential Revision: https://phabricator.freedesktop.org/D1737
-
- 12 Apr, 2017 2 commits
-
-
Fabrice Bellet authored
With this patch, we don't create a new GSource for udp-turn socket, because it would duplicate the packets already received on the base UDP socket, as the underlying GSocket is the same. This is a race condition, because an UDP packet arriving on the base socket, may randomly be handled by the GSource callback created for the base socket (udp-bsd) of the callback created for the udp-turn socket. Moreover this callback already knows how to parse UDP datagrams received from a known turn server. This patch also prevents a subtle bug, when a STUN request is received directly from a peer, is handled by the udp turn socket. If the agent already has a valid permission for this remote candidate, established for another pair, it will happily send the STUN reply through the turn relay. This generates a source address mismatch on the peer agent, when it'll receive the STUN response from the turn relay instead of the initial address the request has been sent to. Differential Revision: https://phabricator.freedesktop.org/D932
-
Fabrice Bellet authored
According to RFC 5389, section 7.2.1, a special timeout is applied to the last retransmission (Rm * RTO), with Rm default value of 16, instead of (64 * RTO), 2^6 when the number of transmissions Rc is set to 7. As spotted by Olivier Crete, stun_timer_* is a public API, that cannot be changed, and the initial delay (RTO) is not preserved in the stun_timer_s struct. So we use a hack that implicitely guess Rm from the number of transmissions Rc, by generalizing the default value of the spec for Rm and Rc to other values of Rc passed in stun_timer_start( According to the spec, with the default value of Rc=7, the last delay should be (64 * RTO), and it is instead (16 * RTO). So the last delay can be computed by dividing the penultimate delay by two, instead of multiplying it by two. Differential Revision: https://phabricator.freedesktop.org/D1108
-
- 11 Apr, 2017 5 commits
-
-
Olivier Crête authored
If we disable ice-tcp or ice-udp, ignore the remote candidates for those types.
-
Olivier Crête authored
It was checking when the pair was created, but the role may have already changed when the request is sent.
-
Olivier Crête authored
https://phabricator.freedesktop.org/T104Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1717
-
Olivier Crête authored
This is required by the WebRTC spec. Remove test-mainloop as it doesnt even try to do a negotiation. https://phabricator.freedesktop.org/T104 Differential Revision: https://phabricator.freedesktop.org/D1716
-
Olivier Crête authored
Add a function that can check if two candidates point to the same place. https://phabricator.freedesktop.org/T104Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1715
-
- 05 Apr, 2017 3 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
This fixes the valgrind integration with the new test drivers.
-
- 04 Apr, 2017 7 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
The same variable was used for return values from NiceSocket and for the internal enum, but 0 and -1 have different meanings in both.
-
Olivier Crête authored
-
Olivier Crête authored
Various little things, none of which should make a functional difference.
-
Olivier Crête authored
It exits the loop immediately, so no point to set the variable. And it makes the clang static analyzer happy.
-
Olivier Crête authored
It's now an array, not a pointer, so needs to test to emptyness. It's a bugfix on the previous commit, 59ce41df
-
Miguel París Díaz authored
Consider that the answer is received when remote credentials are set instead of when a remote candidate is set, which could not happen or could cause more delay for the connection establishment. Ported to git master by Olivier Crête Differential Revision: https://phabricator.freedesktop.org/D1704
-
- 03 Apr, 2017 15 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
There was a confusion and it tested against a value not in the enum.
-
Olivier Crête authored
We don't have or call noreturn functions in practice and it makes the stun test build fail on clang.
-
Olivier Crête authored
This makes clang happy.
-
Olivier Crête authored
clang on recent macOS seems to only emit a warning on unknown flags which makes this test fail and then when using Werror, it makes the compiler test fail too.
-
Olivier Crête authored
It's only nonce level randomness, not long term key level. Differential Revision: https://phabricator.freedesktop.org/D1711
-
Olivier Crête authored
GLib already uses it, instead of adding another dep. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1705
-
Jakub Adam authored
Using a IPv6 local address to connect to a IPv4 relay just creates an extra discovery attempt that will not provide something useful. This commit fixes another place of TURN discovery creation which was omitted in fc0d3744. In my case it cuts down up to ~15 seconds from candidate gathering phase, making it almost instantaneous. Reviewed-by:
Olivier Crête <olivier.crete@collabora.com> Differential Revision: https://phabricator.freedesktop.org/D1709
-
Jakub Adam authored
Those may have previously been silently ignored. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1708
-
Jakub Adam authored
There were two almost consecutive verbose debugs containing basically identical information. Merge them into one message that is printed only when something was actually received. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1707
-
Jakub Adam authored
agent_recv_message_unlocked() always receives a single message and returns a RecvStatus code. Avoid weird debugs like "received -1 valid messages" (when retval is RECV_WOULD_BLOCK) and print the message only when something was actually received. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1706
-
- 01 Apr, 2017 2 commits
-
-
Olivier Crête authored
They're not present int he 1.5.0 release, so require the newer one.
-
Olivier Crête authored
-