1. 03 May, 2022 4 commits
  2. 20 Apr, 2022 1 commit
    • Olivier Crête's avatar
      agent: Hold ref while doing async close · 41ac7386
      Olivier Crête authored
      It's possible that the callback will be called synchronously during the
      close function, in this case, we need to be ready to the last reference
      to the agent to be dropped in this callback.
      
      This fix was suggested by Fabrice Bellet
      
      Fixes #153
      41ac7386
  3. 06 Apr, 2022 1 commit
    • Johan Sternerup's avatar
      Don't try to use link-local addresses outside local network · 526eec8b
      Johan Sternerup authored
      If we have gathered a host IP-address that is link-local we should
      never try to use it for anything else than trying to match it with
      another link-local address. Some routers seem to have problems with
      traffic from link-local addresses destined at external IP-addresses.
      By definition link-local addresses should stay local so there's no
      reason to access STUN/TURN from it or try to form a candidate with
      another address that is not link-local.
      526eec8b
  4. 21 Mar, 2022 2 commits
    • Nirbheek Chauhan's avatar
      agent: Fix warning about required glib version · 64271494
      Nirbheek Chauhan authored
      ../agent/discovery.c: In function ‘on_refresh_remove_timeout’:
      ../agent/discovery.c:203:13: warning: Not available before 2.60
        203 |       G_GNUC_FALLTHROUGH;
            |             ^~~~~~~~~~~~~
      
      ../agent/conncheck.c: In function ‘priv_turn_allocate_refresh_retransmissions_tick_agent_locked’:
      ../agent/conncheck.c:1656:13: warning: Not available before 2.60
       1656 |       G_GNUC_FALLTHROUGH;
            |             ^~~~~~~~~~~~~
      
      The comment /* fall through */ is enough to cause GCC and Clang to not
      emit the implicit-fallthrough warning.
      64271494
    • Nirbheek Chauhan's avatar
      agent: Convert g_print() to nice_debug() · cccdabfd
      Nirbheek Chauhan authored
      This was probably added by mistake.
      cccdabfd
  5. 26 Jan, 2022 1 commit
  6. 26 Nov, 2021 4 commits
  7. 22 Nov, 2021 12 commits
  8. 15 Nov, 2021 1 commit
    • Nirbheek Chauhan's avatar
      meson: Add agent include dir to uninstalled pkgconfig file · 5123cea3
      Nirbheek Chauhan authored
      Meson picks up the includedirs from the library target that it is
      building the pkgconfig file for. Since libnice's headers are split
      into the nice/ and agent/ subdirs, we need to add agent/ to
      include_directories: so that it's automatically added to the
      uninstalled pkgconfig file by Meson.
      5123cea3
  9. 03 Nov, 2021 1 commit
  10. 02 Nov, 2021 8 commits
  11. 01 Nov, 2021 4 commits
    • Fabrice Bellet's avatar
      agent: ensure suceeded and discovered pairs fail the same time · 01e2de64
      Fabrice Bellet authored
      This patch ensures that related succeeded-discovered pairs change to
      state failed simultaneously, to avoid leaving dangling pointers if one
      is freeed while the other is still in the conncheck list. Such
      transition is very rare, and only occurs in regular nomination mode,
      when the network conditions change between the time the pair is
      initially discovered and the time it is rechecked with the use-candidate
      flag.
      01e2de64
    • Xavier Claessens's avatar
      Fix error when crypto/ssl libs are found without pkg-config · 574f44b4
      Xavier Claessens authored
      In that case crypto_dep is a list and we can't call .found() method.
      574f44b4
    • Juan Navarro's avatar
      agent: Unify constructors into nice_agent_new_full · bddeefdf
      Juan Navarro authored
      Instead of having 3 independent implementations, make the simpler
      versions delegate into the full one.
      
      The simplest constructor needs to pass "no option", for which no
      constant exists in the NiceAgentOption enum. Thus the new
      NICE_AGENT_OPTION_NONE constant is added to reflect this possibility.
      bddeefdf
    • Ole André Vadla Ravnås's avatar
      Use native crypto support on Windows by default · 48a8a498
      Ole André Vadla Ravnås authored
      As we only need a few primitives there isn't much OS-specific code
      needed, and for applications that don't already depend on OpenSSL or
      GnuTLS it simplifies the build process quite a lot.
      
      Note that we use the vintage WinCrypt APIs as the Cryptography Next
      Generation APIs are only available on Vista and newer.
      48a8a498
  12. 04 Oct, 2021 1 commit
    • Fabrice Bellet's avatar
      component: reset the stun agent on ice restart · 47a96334
      Fabrice Bellet authored
      The stun agent may contain references to the password previously stored
      in some remote candidates, freeed by nice_component_restart(), that were
      used by keep-alive stun requests. These stun replies may arrive later
      after ice has been restarted. Since the remote candidates are freeed
      when ice is restarted, the stun agent must be reset to get rid of these
      related references.
      47a96334