Commit e5bdf371 authored by Youness Alaoui's avatar Youness Alaoui

Check for username/password lenght of socks5 proxy to avoid a buffer overflow

parent 2df96df5
...@@ -193,9 +193,17 @@ socket_recv (NiceSocket *sock, NiceAddress *from, guint len, gchar *buf) ...@@ -193,9 +193,17 @@ socket_recv (NiceSocket *sock, NiceAddress *from, guint len, gchar *buf)
if (priv->username) if (priv->username)
ulen = strlen (priv->username); ulen = strlen (priv->username);
if (ulen > 255) {
nice_debug ("Socks5 username length > 255");
goto error;
}
if (priv->password) if (priv->password)
plen = strlen (priv->password); plen = strlen (priv->password);
if (plen > 255) {
nice_debug ("Socks5 password length > 255");
goto error;
}
msg[len++] = 0x01; /* auth version */ msg[len++] = 0x01; /* auth version */
msg[len++] = ulen; /* username length */ msg[len++] = ulen; /* username length */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment