Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
libnice
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
libnice
Commits
df5b9e64
Commit
df5b9e64
authored
Jan 22, 2019
by
Olivier Crête
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
turn: Replace magic numbers with define
parent
2e044ea1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
20 additions
and
18 deletions
+20
-18
agent/conncheck.c
agent/conncheck.c
+4
-4
socket/udp-turn.c
socket/udp-turn.c
+16
-14
No files found.
agent/conncheck.c
View file @
df5b9e64
...
@@ -3674,8 +3674,8 @@ static gboolean priv_map_reply_to_relay_request (NiceAgent *agent, StunMessage *
...
@@ -3674,8 +3674,8 @@ static gboolean priv_map_reply_to_relay_request (NiceAgent *agent, StunMessage *
STUN_MESSAGE_RETURN_SUCCESS
&&
STUN_MESSAGE_RETURN_SUCCESS
&&
recv_realm
!=
NULL
&&
recv_realm_len
>
0
)
{
recv_realm
!=
NULL
&&
recv_realm_len
>
0
)
{
if
(
code
==
438
||
if
(
code
==
STUN_ERROR_STALE_NONCE
||
(
code
==
401
&&
(
code
==
STUN_ERROR_UNAUTHORIZED
&&
!
(
recv_realm_len
==
sent_realm_len
&&
!
(
recv_realm_len
==
sent_realm_len
&&
sent_realm
!=
NULL
&&
sent_realm
!=
NULL
&&
memcmp
(
sent_realm
,
recv_realm
,
sent_realm_len
)
==
0
)))
{
memcmp
(
sent_realm
,
recv_realm
,
sent_realm_len
)
==
0
)))
{
...
@@ -3764,8 +3764,8 @@ static gboolean priv_map_reply_to_relay_refresh (NiceAgent *agent, StunMessage *
...
@@ -3764,8 +3764,8 @@ static gboolean priv_map_reply_to_relay_refresh (NiceAgent *agent, StunMessage *
STUN_MESSAGE_RETURN_SUCCESS
&&
STUN_MESSAGE_RETURN_SUCCESS
&&
recv_realm
!=
NULL
&&
recv_realm_len
>
0
)
{
recv_realm
!=
NULL
&&
recv_realm_len
>
0
)
{
if
(
code
==
438
||
if
(
code
==
STUN_ERROR_STALE_NONCE
||
(
code
==
401
&&
(
code
==
STUN_ERROR_UNAUTHORIZED
&&
!
(
recv_realm_len
==
sent_realm_len
&&
!
(
recv_realm_len
==
sent_realm_len
&&
sent_realm
!=
NULL
&&
sent_realm
!=
NULL
&&
memcmp
(
sent_realm
,
recv_realm
,
sent_realm_len
)
==
0
)))
{
memcmp
(
sent_realm
,
recv_realm
,
sent_realm_len
)
==
0
)))
{
...
...
socket/udp-turn.c
View file @
df5b9e64
...
@@ -1451,13 +1451,14 @@ nice_udp_turn_socket_parse_recv (NiceSocket *sock, NiceSocket **from_sock,
...
@@ -1451,13 +1451,14 @@ nice_udp_turn_socket_parse_recv (NiceSocket *sock, NiceSocket **from_sock,
/* check for unauthorized error response */
/* check for unauthorized error response */
if
(
stun_message_find_error
(
&
msg
,
&
code
)
==
if
(
stun_message_find_error
(
&
msg
,
&
code
)
==
STUN_MESSAGE_RETURN_SUCCESS
&&
STUN_MESSAGE_RETURN_SUCCESS
&&
(
code
==
438
||
(
code
==
401
&&
(
code
==
STUN_ERROR_STALE_NONCE
||
!
(
recv_realm
!=
NULL
&&
(
code
==
STUN_ERROR_UNAUTHORIZED
&&
recv_realm_len
>
0
&&
!
(
recv_realm
!=
NULL
&&
recv_realm_len
==
sent_realm_len
&&
recv_realm_len
>
0
&&
sent_realm
!=
NULL
&&
recv_realm_len
==
sent_realm_len
&&
memcmp
(
sent_realm
,
recv_realm
,
sent_realm
!=
NULL
&&
sent_realm_len
)
==
0
))))
{
memcmp
(
sent_realm
,
recv_realm
,
sent_realm_len
)
==
0
))))
{
g_free
(
priv
->
current_binding_msg
);
g_free
(
priv
->
current_binding_msg
);
priv
->
current_binding_msg
=
NULL
;
priv
->
current_binding_msg
=
NULL
;
...
@@ -1552,13 +1553,14 @@ nice_udp_turn_socket_parse_recv (NiceSocket *sock, NiceSocket **from_sock,
...
@@ -1552,13 +1553,14 @@ nice_udp_turn_socket_parse_recv (NiceSocket *sock, NiceSocket **from_sock,
/* check for unauthorized error response */
/* check for unauthorized error response */
if
(
stun_message_find_error
(
&
msg
,
&
code
)
==
if
(
stun_message_find_error
(
&
msg
,
&
code
)
==
STUN_MESSAGE_RETURN_SUCCESS
&&
STUN_MESSAGE_RETURN_SUCCESS
&&
(
code
==
438
||
(
code
==
401
&&
(
code
==
STUN_ERROR_STALE_NONCE
||
!
(
recv_realm
!=
NULL
&&
(
code
==
STUN_ERROR_UNAUTHORIZED
&&
recv_realm_len
>
0
&&
!
(
recv_realm
!=
NULL
&&
recv_realm_len
==
sent_realm_len
&&
recv_realm_len
>
0
&&
sent_realm
!=
NULL
&&
recv_realm_len
==
sent_realm_len
&&
memcmp
(
sent_realm
,
recv_realm
,
sent_realm
!=
NULL
&&
sent_realm_len
)
==
0
))))
{
memcmp
(
sent_realm
,
recv_realm
,
sent_realm_len
)
==
0
))))
{
priv
->
pending_permissions
=
g_list_delete_link
(
priv
->
pending_permissions
=
g_list_delete_link
(
priv
->
pending_permissions
,
i
);
priv
->
pending_permissions
,
i
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment