Commit c29525c9 authored by Dominik Charousset's avatar Dominik Charousset

Apply new rule regarding `explicit`

parent 1290c7c0
......@@ -133,7 +133,7 @@ base_actor::~base_actor() {
// encapsulates an HTTP request
class client_job : public base_actor {
public:
client_job(actor parent)
explicit client_job(actor parent)
: base_actor(std::move(parent), "client_job", color::blue) {
// nop
}
......@@ -167,7 +167,7 @@ client_job::~client_job() {
class client : public base_actor {
public:
client(const actor& parent)
explicit client(const actor& parent)
: base_actor(parent, "client", color::green),
m_count(0),
m_re(m_rd()),
......@@ -214,7 +214,7 @@ client::~client() {
// manages a CURL session
class curl_worker : public base_actor {
public:
curl_worker(const actor& parent)
explicit curl_worker(const actor& parent)
: base_actor(parent, "curl_worker", color::yellow),
m_curl(nullptr) {
// nop
......
......@@ -27,11 +27,12 @@ struct tree_node {
std::uint32_t value;
std::vector<tree_node> children;
tree_node(std::uint32_t v = 0) : value(v) {
explicit tree_node(std::uint32_t v = 0) : value(v) {
// nop
}
tree_node& add_child(std::uint32_t v = 0) {
children.push_back({ v });
children.emplace_back(v);
return *this;
}
......
......@@ -27,7 +27,9 @@ class binary_writer : public static_visitor<> {
public:
using write_fun = binary_serializer::write_fun;
binary_writer(write_fun& sink) : m_out(sink) {}
explicit binary_writer(write_fun& sink) : m_out(sink) {
// nop
}
template <class T>
static inline void write_int(write_fun& f, const T& value) {
......
......@@ -147,7 +147,7 @@ using local_group_ptr = intrusive_ptr<local_group>;
class local_broker : public event_based_actor {
public:
local_broker(local_group_ptr g) : m_group(std::move(g)) {
explicit local_broker(local_group_ptr g) : m_group(std::move(g)) {
// nop
}
......@@ -297,7 +297,7 @@ using local_group_proxy_ptr = intrusive_ptr<local_group_proxy>;
class proxy_broker : public event_based_actor {
public:
proxy_broker(local_group_proxy_ptr grp) : m_group(std::move(grp)) {
explicit proxy_broker(local_group_proxy_ptr grp) : m_group(std::move(grp)) {
// nop
}
......
......@@ -406,7 +406,7 @@ invoke_message_result local_actor::invoke_message(mailbox_element_ptr& ptr,
struct pending_response_predicate {
public:
pending_response_predicate(message_id mid) : m_mid(mid) {
explicit pending_response_predicate(message_id mid) : m_mid(mid) {
// nop
}
......
......@@ -60,7 +60,7 @@ struct log_event {
log_event* next;
log_event* prev;
std::string msg;
log_event(std::string logmsg = "")
explicit log_event(std::string logmsg = "")
: next(nullptr),
prev(nullptr),
msg(std::move(logmsg)) {
......
......@@ -139,7 +139,7 @@ class string_serializer : public serializer, public dummy_backend {
}
}
string_serializer(ostream& mout)
explicit string_serializer(ostream& mout)
: super(&m_namespace),
out(mout),
m_namespace(*this),
......@@ -221,7 +221,7 @@ class string_deserializer : public deserializer, public dummy_backend {
using difference_type = string::iterator::difference_type;
string_deserializer(string str)
explicit string_deserializer(string str)
: super(&m_namespace), m_str(std::move(str)), m_namespace(*this) {
m_pos = m_str.begin();
}
......@@ -290,7 +290,9 @@ class string_deserializer : public deserializer, public dummy_backend {
struct from_string_reader : static_visitor<> {
const string& str;
from_string_reader(const string& s) : str(s) {}
explicit from_string_reader(const string& s) : str(s) {
// nop
}
template <class T>
void operator()(T& what) {
istringstream s(str);
......
......@@ -63,7 +63,10 @@ class set_commit_rollback {
using pointer = void**;
set_commit_rollback(const set_commit_rollback&) = delete;
set_commit_rollback& operator=(const set_commit_rollback&) = delete;
set_commit_rollback(pointer ptr) : m_data(ptr), m_pos(0), m_fallback_pos(0) {
explicit set_commit_rollback(pointer ptr)
: m_data(ptr),
m_pos(0),
m_fallback_pos(0) {
// nop
}
inline void inc() {
......
......@@ -491,7 +491,7 @@ protected:
class default_meta_message : public uniform_type_info {
public:
default_meta_message(const std::string& tname) : m_name(tname) {
explicit default_meta_message(const std::string& tname) : m_name(tname) {
std::vector<std::string> elements;
split(elements, tname, is_any_of("+"));
auto uti_map = detail::singletons::get_uniform_type_info_map();
......@@ -559,7 +559,7 @@ class default_meta_message : public uniform_type_info {
template <class Iterator>
struct builtin_types_helper {
Iterator pos;
builtin_types_helper(Iterator first) : pos(first) {
explicit builtin_types_helper(Iterator first) : pos(first) {
// nop
}
void operator()() const {
......
......@@ -61,7 +61,7 @@ CAF_TEST(basics) {
}
struct send_to_self {
send_to_self(blocking_actor* self) : m_self(self) {
explicit send_to_self(blocking_actor* self) : m_self(self) {
// nop
}
template <class... Ts>
......
......@@ -34,7 +34,7 @@ using done_atom = atom_constant<atom("done")>;
CAF_TEST(constructor_attach) {
class testee : public event_based_actor {
public:
testee(actor buddy) : m_buddy(buddy) {
explicit testee(actor buddy) : m_buddy(buddy) {
attach_functor([=](uint32_t reason) {
send(m_buddy, done_atom::value, reason);
});
......
......@@ -45,7 +45,7 @@ using class1ptr = intrusive_ptr<class1>;
class class0 : public ref_counted {
public:
class0(bool subtype = false) : m_subtype(subtype) {
explicit class0(bool subtype = false) : m_subtype(subtype) {
if (!subtype) {
++class0_instances;
}
......
......@@ -58,24 +58,18 @@ behavior testee::make_behavior() {
class tester : public event_based_actor {
public:
tester(actor aut);
~tester();
explicit tester(actor aut)
: m_aut(std::move(aut)),
m_msg(make_message(1, 2, 3)) {
// nop
}
behavior make_behavior() override;
private:
actor m_aut;
message m_msg;
};
tester::tester(actor aut) :
m_aut(std::move(aut)),
m_msg(make_message(1, 2, 3)) {
// nop
}
tester::~tester() {
// nop
}
behavior tester::make_behavior() {
monitor(m_aut);
send(m_aut, m_msg);
......
......@@ -103,7 +103,7 @@ event_testee::~event_testee() {
actor spawn_event_testee2(actor parent) {
struct impl : event_based_actor {
actor parent;
impl(actor parent_actor) : parent(parent_actor) {
explicit impl(actor parent_actor) : parent(std::move(parent_actor)) {
inc_actor_instances();
}
~impl() {
......@@ -305,7 +305,9 @@ struct master : event_based_actor {
struct slave : event_based_actor {
slave(actor master_actor) : master{master_actor} { }
explicit slave(actor master_actor) : master{master_actor} {
// nop
}
behavior make_behavior() override {
link_to(master);
......@@ -763,7 +765,7 @@ CAF_TEST(typed_await) {
CAF_TEST(constructor_attach) {
class testee : public event_based_actor {
public:
testee(actor buddy) : m_buddy(buddy) {
explicit testee(actor buddy) : m_buddy(std::move(buddy)) {
attach_functor([=](uint32_t reason) {
send(buddy, ok_atom::value, reason);
});
......
......@@ -66,7 +66,7 @@ struct float_or_int : event_based_actor {
class popular_actor : public event_based_actor { // popular actors have a buddy
public:
popular_actor(const actor& buddy_arg) : m_buddy(buddy_arg) {
explicit popular_actor(const actor& buddy_arg) : m_buddy(buddy_arg) {
// nop
}
......@@ -99,7 +99,7 @@ class popular_actor : public event_based_actor { // popular actors have a buddy
class A : public popular_actor {
public:
A(const actor& buddy_arg) : popular_actor(buddy_arg) {
explicit A(const actor& buddy_arg) : popular_actor(buddy_arg) {
// nop
}
......@@ -124,7 +124,7 @@ class A : public popular_actor {
class B : public popular_actor {
public:
B(const actor& buddy_arg) : popular_actor(buddy_arg) {
explicit B(const actor& buddy_arg) : popular_actor(buddy_arg) {
// nop
}
......@@ -170,7 +170,7 @@ class C : public event_based_actor {
class D : public popular_actor {
public:
D(const actor& buddy_arg) : popular_actor(buddy_arg) {
explicit D(const actor& buddy_arg) : popular_actor(buddy_arg) {
// nop
}
......
......@@ -35,7 +35,7 @@ namespace {
* A wrapper for the supervisor backend provided by boost::asio.
*/
struct asio_supervisor : public multiplexer::supervisor {
asio_supervisor(io_backend& iob) : work(iob) {
explicit asio_supervisor(io_backend& iob) : work(iob) {
// nop
}
......
......@@ -47,7 +47,7 @@ basp_broker::payload_writer::~payload_writer() {
template <class F>
class functor_payload_writer : public basp_broker::payload_writer {
public:
functor_payload_writer(F fun) : m_fun(fun) {
explicit functor_payload_writer(F fun) : m_fun(fun) {
// nop
}
......@@ -65,7 +65,7 @@ class functor_payload_writer : public basp_broker::payload_writer {
template <class F>
functor_payload_writer<F> make_payload_writer(F fun) {
return {fun};
return functor_payload_writer<F>{fun};
}
basp_broker::basp_broker(middleman& pref) : broker(pref), m_namespace(*this) {
......
......@@ -622,7 +622,7 @@ default_multiplexer& get_multiplexer_singleton() {
multiplexer::supervisor_ptr default_multiplexer::make_supervisor() {
class impl : public multiplexer::supervisor {
public:
impl(default_multiplexer* thisptr) : m_this(thisptr) {
explicit impl(default_multiplexer* thisptr) : m_this(thisptr) {
// nop
}
~impl() {
......@@ -973,7 +973,7 @@ void default_socket::close_read() {
class socket_guard {
public:
socket_guard(native_socket fd) : m_fd(fd) {
explicit socket_guard(native_socket fd) : m_fd(fd) {
// nop
}
......
......@@ -121,7 +121,7 @@ class uti_impl : public detail::abstract_uniform_type_info<T> {
public:
using super = detail::abstract_uniform_type_info<T>;
uti_impl(const char* tname) : super(tname) {
explicit uti_impl(const char* tname) : super(tname) {
// nop
}
......
......@@ -232,7 +232,7 @@ void await_down(event_based_actor* self, actor ptr, F continuation) {
class client : public event_based_actor {
public:
client(actor server) : m_server(std::move(server)) {
explicit client(actor server) : m_server(std::move(server)) {
// nop
}
......@@ -326,7 +326,7 @@ class server : public event_based_actor {
return await_spawn_ping();
}
server(bool run_in_loop = false) : m_run_in_loop(run_in_loop) {
explicit server(bool run_in_loop = false) : m_run_in_loop(run_in_loop) {
// nop
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment