Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
A
Actor Framework
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
Actor Framework
Commits
bd9c5704
Commit
bd9c5704
authored
Jul 25, 2023
by
Dominik Charousset
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1507
parents
15ab3fd7
24ca2859
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
36 additions
and
2 deletions
+36
-2
CHANGELOG.md
CHANGELOG.md
+1
-0
libcaf_core/caf/inspector_access.hpp
libcaf_core/caf/inspector_access.hpp
+4
-1
libcaf_core/caf/save_inspector.hpp
libcaf_core/caf/save_inspector.hpp
+1
-1
libcaf_core/test/load_inspector.cpp
libcaf_core/test/load_inspector.cpp
+15
-0
libcaf_core/test/save_inspector.cpp
libcaf_core/test/save_inspector.cpp
+15
-0
No files found.
CHANGELOG.md
View file @
bd9c5704
...
@@ -45,6 +45,7 @@ is based on [Keep a Changelog](https://keepachangelog.com).
...
@@ -45,6 +45,7 @@ is based on [Keep a Changelog](https://keepachangelog.com).
-
Fix a regression in
`--dump-config`
that caused CAF applications to emit
-
Fix a regression in
`--dump-config`
that caused CAF applications to emit
malformed output.
malformed output.
-
Fix handling of WebSocket frames that are exactly on the 65535 byte limit.
-
Fix handling of WebSocket frames that are exactly on the 65535 byte limit.
-
Fix crash when using a fallback value for optional values (#1427).
## [0.19.2] - 2023-06-13
## [0.19.2] - 2023-06-13
...
...
libcaf_core/caf/inspector_access.hpp
View file @
bd9c5704
...
@@ -396,7 +396,10 @@ struct optional_inspector_access {
...
@@ -396,7 +396,10 @@ struct optional_inspector_access {
template
<
class
Inspector
,
class
IsPresent
,
class
Get
>
template
<
class
Inspector
,
class
IsPresent
,
class
Get
>
static
bool
save_field
(
Inspector
&
f
,
std
::
string_view
field_name
,
static
bool
save_field
(
Inspector
&
f
,
std
::
string_view
field_name
,
IsPresent
&
is_present
,
Get
&
get
)
{
IsPresent
&
is_present
,
Get
&
get
)
{
return
detail
::
save_field
(
f
,
field_name
,
is_present
,
get
);
auto
deref_get
=
[
&
get
]()
->
decltype
(
auto
)
{
return
traits
::
deref_save
(
get
());
};
return
detail
::
save_field
(
f
,
field_name
,
is_present
,
deref_get
);
}
}
template
<
class
Inspector
,
class
IsValid
,
class
SyncValue
>
template
<
class
Inspector
,
class
IsValid
,
class
SyncValue
>
...
...
libcaf_core/caf/save_inspector.hpp
View file @
bd9c5704
...
@@ -75,7 +75,7 @@ public:
...
@@ -75,7 +75,7 @@ public:
template
<
class
Inspector
>
template
<
class
Inspector
>
bool
operator
()(
Inspector
&
f
)
{
bool
operator
()(
Inspector
&
f
)
{
auto
is_present
=
[
this
]
{
return
*
val
!=
fallback
;
};
auto
is_present
=
[
this
]
{
return
*
val
!=
fallback
;
};
auto
get
=
[
this
]
{
return
*
val
;
};
auto
get
=
[
this
]
()
->
decltype
(
auto
)
{
return
*
val
;
};
return
detail
::
save_field
(
f
,
field_name
,
is_present
,
get
);
return
detail
::
save_field
(
f
,
field_name
,
is_present
,
get
);
}
}
...
...
libcaf_core/test/load_inspector.cpp
View file @
bd9c5704
...
@@ -769,4 +769,19 @@ end object)_";
...
@@ -769,4 +769,19 @@ end object)_";
}
}
}
}
TEST_CASE
(
"GH-1427 regression"
)
{
struct
opt_test
{
std
::
optional
<
int
>
val
;
};
auto
x
=
opt_test
{};
CHECK
(
f
.
object
(
x
).
fields
(
f
.
field
(
"val"
,
x
.
val
).
fallback
(
std
::
nullopt
)));
CHECK
(
!
f
.
get_error
());
std
::
string
baseline
=
R"_(
begin object anonymous
begin optional field val
end field
end object)_"
;
CHECK_EQ
(
f
.
log
,
baseline
);
}
END_FIXTURE_SCOPE
()
END_FIXTURE_SCOPE
()
libcaf_core/test/save_inspector.cpp
View file @
bd9c5704
...
@@ -809,4 +809,19 @@ end object)_";
...
@@ -809,4 +809,19 @@ end object)_";
}
}
}
}
TEST_CASE
(
"GH-1427 regression"
)
{
struct
opt_test
{
std
::
optional
<
int
>
val
;
};
auto
x
=
opt_test
{};
CHECK
(
f
.
object
(
x
).
fields
(
f
.
field
(
"val"
,
x
.
val
).
fallback
(
std
::
nullopt
)));
CHECK
(
!
f
.
get_error
());
std
::
string
baseline
=
R"_(
begin object anonymous
begin optional field val
end field
end object)_"
;
CHECK_EQ
(
f
.
log
,
baseline
);
}
END_FIXTURE_SCOPE
()
END_FIXTURE_SCOPE
()
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment