Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
A
Actor Framework
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
Actor Framework
Commits
a87ac5e6
Commit
a87ac5e6
authored
Aug 08, 2023
by
Dominik Charousset
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix the behavior of take(0) on observables
parent
27b781cd
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
101 additions
and
9 deletions
+101
-9
CHANGELOG.md
CHANGELOG.md
+4
-0
libcaf_core/caf/flow/observable.test.cpp
libcaf_core/caf/flow/observable.test.cpp
+88
-0
libcaf_core/caf/flow/step/take.hpp
libcaf_core/caf/flow/step/take.hpp
+9
-9
No files found.
CHANGELOG.md
View file @
a87ac5e6
...
...
@@ -48,6 +48,10 @@ is based on [Keep a Changelog](https://keepachangelog.com).
malformed output.
-
Fix handling of WebSocket frames that are exactly on the 65535 byte limit.
-
Fix crash when using a fallback value for optional values (#1427).
-
Using
`take(0)`
on an observable now properly creates an observable that calls
`on_complete`
on its subscriber on the first activity of the source
observable. Previously, the created observable would never reach its threshold
and attempt to buffer all values indefinitely.
## [0.19.2] - 2023-06-13
...
...
libcaf_core/caf/flow/observable.test.cpp
0 → 100644
View file @
a87ac5e6
// This file is part of CAF, the C++ Actor Framework. See the file LICENSE in
// the main distribution directory for license terms and copyright or visit
// https://github.com/actor-framework/actor-framework/blob/master/LICENSE.
#include "caf/flow/observable.hpp"
#include "caf/test/caf_test_main.hpp"
#include "caf/test/fixture/flow.hpp"
#include "caf/test/nil.hpp"
#include "caf/test/test.hpp"
using
caf
::
test
::
nil
;
using
std
::
vector
;
using
namespace
caf
;
WITH_FIXTURE
(
test
::
fixture
::
flow
)
{
// Note: we always double the checks for the operator-under-test by calling it
// once on a blueprint and once on an actual observable. This ensures that
// the blueprint and the observable both offer the same functionality.
TEST
(
"skip(n) skips the first n elements in a range of size m"
)
{
SECTION
(
"skip(0) does nothing"
)
{
SECTION
(
"blueprint"
)
{
check_eq
(
collect
(
range
(
1
,
0
).
skip
(
0
)),
nil
);
check_eq
(
collect
(
range
(
1
,
1
).
skip
(
0
)),
vector
{
1
});
check_eq
(
collect
(
range
(
1
,
2
).
skip
(
0
)),
vector
{
1
,
2
});
check_eq
(
collect
(
range
(
1
,
3
).
skip
(
0
)),
vector
{
1
,
2
,
3
});
}
SECTION
(
"observable"
)
{
check_eq
(
collect
(
mat
(
range
(
1
,
0
)).
skip
(
0
)),
nil
);
check_eq
(
collect
(
mat
(
range
(
1
,
1
)).
skip
(
0
)),
vector
{
1
});
check_eq
(
collect
(
mat
(
range
(
1
,
2
)).
skip
(
0
)),
vector
{
1
,
2
});
check_eq
(
collect
(
mat
(
range
(
1
,
3
)).
skip
(
0
)),
vector
{
1
,
2
,
3
});
}
}
SECTION
(
"skip(n) truncates the first n elements if n < m"
)
{
SECTION
(
"blueprint"
)
{
check_eq
(
collect
(
range
(
1
,
3
).
skip
(
1
)),
vector
{
2
,
3
});
check_eq
(
collect
(
range
(
1
,
3
).
skip
(
2
)),
vector
{
3
});
}
SECTION
(
"observable"
)
{
check_eq
(
collect
(
mat
(
range
(
1
,
3
)).
skip
(
1
)),
vector
{
2
,
3
});
check_eq
(
collect
(
mat
(
range
(
1
,
3
)).
skip
(
2
)),
vector
{
3
});
}
}
SECTION
(
"skip(n) drops all elements if n >= m"
)
{
SECTION
(
"blueprint"
)
{
check_eq
(
collect
(
range
(
1
,
3
).
skip
(
3
)),
nil
);
check_eq
(
collect
(
range
(
1
,
3
).
skip
(
4
)),
nil
);
}
SECTION
(
"observable"
)
{
check_eq
(
collect
(
mat
(
range
(
1
,
3
)).
skip
(
3
)),
nil
);
check_eq
(
collect
(
mat
(
range
(
1
,
3
)).
skip
(
4
)),
nil
);
}
}
SECTION
(
"skip(n) stops early when the next operator stops early"
)
{
SECTION
(
"blueprint"
)
{
check_eq
(
collect
(
range
(
1
,
5
).
skip
(
2
).
take
(
0
)),
nil
);
check_eq
(
collect
(
range
(
1
,
5
).
skip
(
2
).
take
(
1
)),
vector
{
3
});
check_eq
(
collect
(
range
(
1
,
5
).
skip
(
2
).
take
(
2
)),
vector
{
3
,
4
});
check_eq
(
collect
(
range
(
1
,
5
).
skip
(
2
).
take
(
3
)),
vector
{
3
,
4
,
5
});
check_eq
(
collect
(
range
(
1
,
5
).
skip
(
2
).
take
(
4
)),
vector
{
3
,
4
,
5
});
}
SECTION
(
"observable"
)
{
check_eq
(
collect
(
mat
(
range
(
1
,
5
)).
skip
(
2
).
take
(
0
)),
nil
);
check_eq
(
collect
(
mat
(
range
(
1
,
5
)).
skip
(
2
).
take
(
1
)),
vector
{
3
});
check_eq
(
collect
(
mat
(
range
(
1
,
5
)).
skip
(
2
).
take
(
2
)),
vector
{
3
,
4
});
check_eq
(
collect
(
mat
(
range
(
1
,
5
)).
skip
(
2
).
take
(
3
)),
vector
{
3
,
4
,
5
});
check_eq
(
collect
(
mat
(
range
(
1
,
5
)).
skip
(
2
).
take
(
4
)),
vector
{
3
,
4
,
5
});
}
}
SECTION
(
"skip(n) forwards errors"
)
{
SECTION
(
"blueprint"
)
{
check_eq
(
collect
(
obs_error
().
skip
(
0
)),
sec
::
runtime_error
);
check_eq
(
collect
(
obs_error
().
skip
(
1
)),
sec
::
runtime_error
);
}
SECTION
(
"observable"
)
{
check_eq
(
collect
(
mat
(
obs_error
()).
skip
(
0
)),
sec
::
runtime_error
);
check_eq
(
collect
(
mat
(
obs_error
()).
skip
(
1
)),
sec
::
runtime_error
);
}
}
}
}
// WITH_FIXTURE(test::fixture::flow)
CAF_TEST_MAIN
()
libcaf_core/caf/flow/step/take.hpp
View file @
a87ac5e6
...
...
@@ -29,16 +29,16 @@ public:
template
<
class
Next
,
class
...
Steps
>
bool
on_next
(
const
input_type
&
item
,
Next
&
next
,
Steps
&
...
steps
)
{
if
(
remaining_
>
0
)
{
if
(
next
.
on_next
(
item
,
steps
...))
{
if
(
--
remaining_
>
0
)
{
return
true
;
}
else
{
next
.
on_complete
(
steps
...);
return
false
;
}
}
if
(
next
.
on_next
(
item
,
steps
...))
--
remaining_
;
else
return
false
;
}
return
false
;
if
(
remaining_
==
0
)
{
next
.
on_complete
(
steps
...);
return
false
;
}
return
true
;
}
template
<
class
Next
,
class
...
Steps
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment