Commit 9f36b670 authored by Dominik Charousset's avatar Dominik Charousset

Fix cppcheck warnings

parent a0477b70
...@@ -180,7 +180,7 @@ public: ...@@ -180,7 +180,7 @@ public:
clear(); clear();
} }
explicit operator bool() { explicit operator bool() const {
return cache_ != nullptr; return cache_ != nullptr;
} }
...@@ -235,9 +235,6 @@ void printer_loop(blocking_actor* self) { ...@@ -235,9 +235,6 @@ void printer_loop(blocking_actor* self) {
struct actor_data { struct actor_data {
std::string current_line; std::string current_line;
sink_handle redirect; sink_handle redirect;
actor_data(std::string&& line) : current_line(std::move(line)) {
// nop
}
}; };
using data_map = std::map<actor_addr, actor_data>; using data_map = std::map<actor_addr, actor_data>;
sink_cache fcache; sink_cache fcache;
...@@ -249,7 +246,7 @@ void printer_loop(blocking_actor* self) { ...@@ -249,7 +246,7 @@ void printer_loop(blocking_actor* self) {
return none; return none;
auto i = data.find(addr); auto i = data.find(addr);
if (i == data.end() && insert_missing) { if (i == data.end() && insert_missing) {
i = data.emplace(addr, std::string{}).first; i = data.emplace(addr, actor_data{}).first;
self->monitor(addr); self->monitor(addr);
} }
if (i != data.end()) if (i != data.end())
......
...@@ -69,10 +69,10 @@ actor_pool::policy actor_pool::broadcast() { ...@@ -69,10 +69,10 @@ actor_pool::policy actor_pool::broadcast() {
actor_pool::policy actor_pool::random() { actor_pool::policy actor_pool::random() {
struct impl { struct impl {
impl() { impl() : rd_() {
// nop // nop
} }
impl(const impl&) { impl(const impl&) : rd_() {
// nop // nop
} }
void operator()(uplock& guard, const actor_vec& vec, void operator()(uplock& guard, const actor_vec& vec,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment