Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
A
Actor Framework
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
Actor Framework
Commits
3e1ae2ba
Commit
3e1ae2ba
authored
Dec 22, 2020
by
Dominik Charousset
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Integrate review feedback, round 2
parent
ea11a6e9
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
7 deletions
+21
-7
libcaf_core/caf/config_value_reader.hpp
libcaf_core/caf/config_value_reader.hpp
+2
-0
libcaf_core/test/config_value.cpp
libcaf_core/test/config_value.cpp
+19
-7
No files found.
libcaf_core/caf/config_value_reader.hpp
View file @
3e1ae2ba
...
@@ -171,6 +171,8 @@ public:
...
@@ -171,6 +171,8 @@ public:
bool
value
(
span
<
byte
>
x
)
override
;
bool
value
(
span
<
byte
>
x
)
override
;
private:
private:
// Sets `type` according to the `@type` field in `obj` or to the type ID of
// `settings` as fallback if no such field exists.
bool
fetch_object_type
(
const
settings
*
obj
,
type_id_t
&
type
);
bool
fetch_object_type
(
const
settings
*
obj
,
type_id_t
&
type
);
stack_type
st_
;
stack_type
st_
;
...
...
libcaf_core/test/config_value.cpp
View file @
3e1ae2ba
...
@@ -251,14 +251,26 @@ SCENARIO("get_as can convert config values to integers") {
...
@@ -251,14 +251,26 @@ SCENARIO("get_as can convert config values to integers") {
}
}
}
}
GIVEN
(
"config_values of null, URI, boolean, list or dictionary"
)
{
GIVEN
(
"config_values of null, URI, boolean, list or dictionary"
)
{
WHEN
(
"using get_as with
integer
types"
)
{
WHEN
(
"using get_as with
floating point
types"
)
{
THEN
(
"conversion fails"
)
{
THEN
(
"conversion fails"
)
{
CHECK_EQ
(
get_as
<
int64_t
>
(
cv_null
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
float
>
(
cv_null
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
int64_t
>
(
cv_true
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
float
>
(
cv_true
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
int64_t
>
(
cv_false
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
float
>
(
cv_false
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
int64_t
>
(
cv_empty_uri
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
float
>
(
cv_empty_uri
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
int64_t
>
(
cv_empty_list
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
float
>
(
cv_empty_list
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
int64_t
>
(
cv_empty_dict
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
float
>
(
cv_empty_dict
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
double
>
(
cv_null
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
double
>
(
cv_true
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
double
>
(
cv_false
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
double
>
(
cv_empty_uri
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
double
>
(
cv_empty_list
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
double
>
(
cv_empty_dict
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
long
double
>
(
cv_null
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
long
double
>
(
cv_true
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
long
double
>
(
cv_false
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
long
double
>
(
cv_empty_uri
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
long
double
>
(
cv_empty_list
),
sec
::
conversion_failed
);
CHECK_EQ
(
get_as
<
long
double
>
(
cv_empty_dict
),
sec
::
conversion_failed
);
}
}
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment