Refine #530 again
Have. To. Do. More. Refinements. Here's what happened in the buggy versions: (I think) * `BootReceiver` starts which invokes `Utils.startSsService` which starts `ShadowsocksRunnerService`; * `ShadowsocksRunnerService` binds to `BaseService`; * 1s after it's connected, it invokes `bgService.use` which returns immediately after pushing `use` in the queue since it's an oneway method; * Then `stopSelf` => `detachService`, `BaseService` now have nothing bound to it and not started either (neither foreground nor background), so the system can destroy it any time; (at this point, `BaseService.use` isn't invoked yet) * `com.github.shadowsocks` process then probably exits since booting is a resource-heavy task, anyway it doesn't matter; * Some time later `com.github.shadowsocks:bg` resumes running, and `BaseService` is stopped and destroyed. Now the system is no longer aware of this `BaseService` instance but it isn't garbage collected yet; * `use` is finally invoked; * `startService` is invoked in `startRunner` and the destroyed background service starts running; (bug of Android?) * `startForeground` is invoked in `ShadowsocksNotification` but the system probably refused it since the service itself is already destroyed; * When the main activity UI is brought up and requests binding, `com.github.shadowsocks:bg` which is unaware of the existing instance of `BaseService` creates another `BaseService` and thus everything gets messed up. This commit fixes this by invoking `getState` (which isn't an oneway method) immediately after `use` so that `ShadowsocksRunnerService` will wait for `BaseService` to start itself before destroying itself and its connection to `BaseService`. And thus its return value is not used.
Showing
Please register or sign in to comment