Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
com.ccwangluo.accelerator
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
sheteng
com.ccwangluo.accelerator
Commits
07a48bc2
Commit
07a48bc2
authored
Dec 06, 2017
by
Max Lv
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refine the local socket closing logic
parent
f870093c
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
32 additions
and
11 deletions
+32
-11
core/src/main/java/com/github/shadowsocks/JniHelper.java
core/src/main/java/com/github/shadowsocks/JniHelper.java
+1
-0
core/src/main/jni/jni-helper.cpp
core/src/main/jni/jni-helper.cpp
+6
-0
mobile/src/main/java/com/github/shadowsocks/bg/LocalSocketListener.kt
...ain/java/com/github/shadowsocks/bg/LocalSocketListener.kt
+25
-11
No files found.
core/src/main/java/com/github/shadowsocks/JniHelper.java
View file @
07a48bc2
...
@@ -70,4 +70,5 @@ public class JniHelper {
...
@@ -70,4 +70,5 @@ public class JniHelper {
private
static
native
Object
getExitValueMutex
(
Process
process
);
private
static
native
Object
getExitValueMutex
(
Process
process
);
public
static
native
int
sendFd
(
int
fd
,
String
path
);
public
static
native
int
sendFd
(
int
fd
,
String
path
);
public
static
native
void
close
(
int
fd
);
public
static
native
void
close
(
int
fd
);
public
static
native
void
unlink
(
String
path
);
}
}
core/src/main/jni/jni-helper.cpp
View file @
07a48bc2
...
@@ -72,6 +72,12 @@ JNIEXPORT void JNICALL Java_com_github_shadowsocks_JniHelper_close(JNIEnv *env,
...
@@ -72,6 +72,12 @@ JNIEXPORT void JNICALL Java_com_github_shadowsocks_JniHelper_close(JNIEnv *env,
close
(
fd
);
close
(
fd
);
}
}
JNIEXPORT
void
JNICALL
Java_com_github_shadowsocks_JniHelper_unlink
(
JNIEnv
*
env
,
jobject
thiz
,
jstring
path
)
{
const
char
*
sock_str
=
env
->
GetStringUTFChars
(
path
,
0
);
unlink
(
sock_str
);
env
->
ReleaseStringUTFChars
(
path
,
sock_str
);
}
JNIEXPORT
jint
JNICALL
JNIEXPORT
jint
JNICALL
Java_com_github_shadowsocks_JniHelper_sendFd
(
JNIEnv
*
env
,
jobject
thiz
,
jint
tun_fd
,
jstring
path
)
{
Java_com_github_shadowsocks_JniHelper_sendFd
(
JNIEnv
*
env
,
jobject
thiz
,
jint
tun_fd
,
jstring
path
)
{
int
fd
;
int
fd
;
...
...
mobile/src/main/java/com/github/shadowsocks/bg/LocalSocketListener.kt
View file @
07a48bc2
...
@@ -25,6 +25,7 @@ import android.net.LocalSocket
...
@@ -25,6 +25,7 @@ import android.net.LocalSocket
import
android.net.LocalSocketAddress
import
android.net.LocalSocketAddress
import
android.util.Log
import
android.util.Log
import
com.github.shadowsocks.App.Companion.app
import
com.github.shadowsocks.App.Companion.app
import
com.github.shadowsocks.JniHelper
import
java.io.File
import
java.io.File
import
java.io.IOException
import
java.io.IOException
import
java.util.concurrent.atomic.AtomicReference
import
java.util.concurrent.atomic.AtomicReference
...
@@ -35,26 +36,30 @@ abstract class LocalSocketListener(private val tag: String) : Thread() {
...
@@ -35,26 +36,30 @@ abstract class LocalSocketListener(private val tag: String) : Thread() {
}
}
protected
abstract
val
socketFile
:
File
protected
abstract
val
socketFile
:
File
private
val
serverSocket
=
AtomicReference
<
LocalServer
Socket
?
>()
private
val
localSocket
=
AtomicReference
<
Local
Socket
?
>()
/**
/**
* Inherited class do not need to close input/output streams as they will be closed automatically.
* Inherited class do not need to close input/output streams as they will be closed automatically.
*/
*/
protected
abstract
fun
accept
(
socket
:
LocalSocket
)
protected
abstract
fun
accept
(
socket
:
LocalSocket
)
override
fun
run
()
{
override
fun
run
()
{
socketFile
.
delete
()
try
{
JniHelper
.
unlink
(
socketFile
.
absolutePath
)
val
localSocket
=
LocalSocket
()
Thread
.
sleep
(
1000
)
// trick to close the previous local socket safely
localSocket
.
bind
(
LocalSocketAddress
(
socketFile
.
absolutePath
,
LocalSocketAddress
.
Namespace
.
FILESYSTEM
))
serverSocket
.
set
(
LocalServerSocket
(
localSocket
.
fileDescriptor
))
val
serverSocket
:
LocalServerSocket
?
=
try
{
val
ls
=
LocalSocket
()
localSocket
.
set
(
ls
)
ls
.
bind
(
LocalSocketAddress
(
socketFile
.
absolutePath
,
LocalSocketAddress
.
Namespace
.
FILESYSTEM
))
LocalServerSocket
(
ls
.
fileDescriptor
)
}
catch
(
e
:
IOException
)
{
}
catch
(
e
:
IOException
)
{
Log
.
e
(
tag
,
"unable to bind"
,
e
)
Log
.
e
(
tag
,
"unable to bind"
,
e
)
return
null
}
}
while
(
true
)
{
while
(
true
)
{
val
serverSocket
=
serverSocket
.
get
()
?:
return
try
{
try
{
val
socket
=
serverSocket
.
accept
()
val
socket
=
serverSocket
?.
accept
()
?:
break
try
{
try
{
accept
(
socket
)
accept
(
socket
)
...
@@ -73,13 +78,22 @@ abstract class LocalSocketListener(private val tag: String) : Thread() {
...
@@ -73,13 +78,22 @@ abstract class LocalSocketListener(private val tag: String) : Thread() {
}
catch
(
e
:
IOException
)
{
}
catch
(
e
:
IOException
)
{
Log
.
e
(
tag
,
"Error when accept socket"
,
e
)
Log
.
e
(
tag
,
"Error when accept socket"
,
e
)
app
.
track
(
e
)
app
.
track
(
e
)
return
break
}
}
}
}
try
{
serverSocket
?.
close
()
}
catch
(
e
:
IOException
)
{
Log
.
e
(
tag
,
"Error when closing socket"
,
e
)
app
.
track
(
e
)
}
Log
.
d
(
tag
,
"thread exit"
)
}
}
fun
stopThread
()
{
fun
stopThread
()
{
val
old
=
server
Socket
.
getAndSet
(
null
)
?:
return
val
old
=
local
Socket
.
getAndSet
(
null
)
?:
return
try
{
try
{
old
.
close
()
old
.
close
()
}
catch
(
_
:
Exception
)
{
}
// ignore
}
catch
(
_
:
Exception
)
{
}
// ignore
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment