Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
com.ccwangluo.accelerator
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
sheteng
com.ccwangluo.accelerator
Commits
05c0c0ba
Commit
05c0c0ba
authored
Apr 27, 2018
by
Mygod
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix ConcurrentModificationException
parent
64c48a34
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
23 additions
and
20 deletions
+23
-20
mobile/src/main/java/com/github/shadowsocks/bg/GuardedProcessPool.kt
...main/java/com/github/shadowsocks/bg/GuardedProcessPool.kt
+23
-20
No files found.
mobile/src/main/java/com/github/shadowsocks/bg/GuardedProcessPool.kt
View file @
05c0c0ba
...
...
@@ -31,8 +31,8 @@ import com.github.shadowsocks.utils.thread
import
java.io.File
import
java.io.IOException
import
java.io.InputStream
import
java.util.*
import
java.util.concurrent.ArrayBlockingQueue
import
java.util.concurrent.atomic.AtomicReference
class
GuardedProcessPool
{
companion
object
{
...
...
@@ -57,11 +57,11 @@ class GuardedProcessPool {
pushed
=
true
}
fun
looper
()
{
fun
looper
(
host
:
HashSet
<
Thread
>
)
{
var
process
:
Process
?
=
null
try
{
var
callback
:
(()
->
Unit
)?
=
null
while
(
!
isDestroyed
)
{
while
(
guardThreads
.
get
()
===
host
)
{
if
(
BuildConfig
.
DEBUG
)
Log
.
d
(
TAG
,
"start process: "
+
Commandline
.
toString
(
cmd
))
val
startTime
=
SystemClock
.
elapsedRealtime
()
...
...
@@ -78,11 +78,8 @@ class GuardedProcessPool {
pushException
(
null
)
process
.
waitFor
()
synchronized
(
this
)
{
if
(
SystemClock
.
elapsedRealtime
()
-
startTime
<
1000
)
{
Log
.
w
(
TAG
,
"process exit too fast, stop guard: $cmdName"
)
isDestroyed
=
true
}
if
(
SystemClock
.
elapsedRealtime
()
-
startTime
<
1000
)
{
Log
.
w
(
TAG
,
"process exit too fast, stop guard: $cmdName"
)
}
}
}
catch
(
_
:
InterruptedException
)
{
...
...
@@ -103,26 +100,32 @@ class GuardedProcessPool {
}
}
private
val
guardThreads
=
HashSet
<
Thread
>()
@Volatile
private
var
isDestroyed
=
false
/**
* This is an indication of which thread pool is being active.
* Reading/writing this collection still needs an additional lock to prevent concurrent modification.
*/
private
val
guardThreads
=
AtomicReference
<
HashSet
<
Thread
>>(
HashSet
())
fun
start
(
cmd
:
List
<
String
>,
onRestartCallback
:
(()
->
Unit
)?
=
null
):
GuardedProcessPool
{
val
guard
=
Guard
(
cmd
,
onRestartCallback
)
guardThreads
.
add
(
thread
(
"GuardThread-${guard.cmdName}"
,
block
=
guard
::
looper
))
val
guardThreads
=
guardThreads
.
get
()
synchronized
(
guardThreads
)
{
guardThreads
.
add
(
thread
(
"GuardThread-${guard.cmdName}"
)
{
guard
.
looper
(
guardThreads
)
})
}
val
ioException
=
guard
.
excQueue
.
take
()
if
(
ioException
!==
dummy
)
throw
ioException
return
this
}
fun
killAll
()
{
isDestroyed
=
true
guardThreads
.
forEach
{
it
.
interrupt
()
}
try
{
guardThreads
.
forEach
{
it
.
join
()
}
}
catch
(
_
:
InterruptedException
)
{
}
guardThreads
.
clear
()
isDestroyed
=
false
val
guardThreads
=
guardThreads
.
getAndSet
(
HashSet
())
synchronized
(
guardThreads
)
{
guardThreads
.
forEach
{
it
.
interrupt
()
}
try
{
guardThreads
.
forEach
{
it
.
join
()
}
}
catch
(
_
:
InterruptedException
)
{
}
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment