- 11 Apr, 2017 4 commits
-
-
Olivier Crête authored
It was checking when the pair was created, but the role may have already changed when the request is sent.
-
Olivier Crête authored
https://phabricator.freedesktop.org/T104Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1717
-
Olivier Crête authored
This is required by the WebRTC spec. Remove test-mainloop as it doesnt even try to do a negotiation. https://phabricator.freedesktop.org/T104 Differential Revision: https://phabricator.freedesktop.org/D1716
-
Olivier Crête authored
Add a function that can check if two candidates point to the same place. https://phabricator.freedesktop.org/T104Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1715
-
- 05 Apr, 2017 3 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
This fixes the valgrind integration with the new test drivers.
-
- 04 Apr, 2017 7 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
The same variable was used for return values from NiceSocket and for the internal enum, but 0 and -1 have different meanings in both.
-
Olivier Crête authored
-
Olivier Crête authored
Various little things, none of which should make a functional difference.
-
Olivier Crête authored
It exits the loop immediately, so no point to set the variable. And it makes the clang static analyzer happy.
-
Olivier Crête authored
It's now an array, not a pointer, so needs to test to emptyness. It's a bugfix on the previous commit, 59ce41df
-
Miguel París Díaz authored
Consider that the answer is received when remote credentials are set instead of when a remote candidate is set, which could not happen or could cause more delay for the connection establishment. Ported to git master by Olivier Crête Differential Revision: https://phabricator.freedesktop.org/D1704
-
- 03 Apr, 2017 15 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
There was a confusion and it tested against a value not in the enum.
-
Olivier Crête authored
We don't have or call noreturn functions in practice and it makes the stun test build fail on clang.
-
Olivier Crête authored
This makes clang happy.
-
Olivier Crête authored
clang on recent macOS seems to only emit a warning on unknown flags which makes this test fail and then when using Werror, it makes the compiler test fail too.
-
Olivier Crête authored
It's only nonce level randomness, not long term key level. Differential Revision: https://phabricator.freedesktop.org/D1711
-
Olivier Crête authored
GLib already uses it, instead of adding another dep. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1705
-
Jakub Adam authored
Using a IPv6 local address to connect to a IPv4 relay just creates an extra discovery attempt that will not provide something useful. This commit fixes another place of TURN discovery creation which was omitted in fc0d3744. In my case it cuts down up to ~15 seconds from candidate gathering phase, making it almost instantaneous. Reviewed-by:
Olivier Crête <olivier.crete@collabora.com> Differential Revision: https://phabricator.freedesktop.org/D1709
-
Jakub Adam authored
Those may have previously been silently ignored. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1708
-
Jakub Adam authored
There were two almost consecutive verbose debugs containing basically identical information. Merge them into one message that is printed only when something was actually received. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1707
-
Jakub Adam authored
agent_recv_message_unlocked() always receives a single message and returns a RecvStatus code. Avoid weird debugs like "received -1 valid messages" (when retval is RECV_WOULD_BLOCK) and print the message only when something was actually received. Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.freedesktop.org/D1706
-
- 01 Apr, 2017 2 commits
-
-
Olivier Crête authored
They're not present int he 1.5.0 release, so require the newer one.
-
Olivier Crête authored
-
- 31 Mar, 2017 8 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Philip Withnall authored
Now that libstun depends on libgcrypt, we might as well use its SHA1 hash support, rather than carrying around our own. Differential Revision: https://phabricator.freedesktop.org/D1612
-
Philip Withnall authored
Now that libstun depends on libgcrypt, we might as well use its MD5 hash support, rather than carrying around our own. Differential Revision: https://phabricator.freedesktop.org/D1611
-
Philip Withnall authored
Previously, a custom Mersenne Twister PRNG was used, which is not securely random. In addition, its seeding fell back to wall-clock time, which is typically predictable. This uses libgcrypt on Linux but retains the Windows code which uses the Windows crypt API. Differential Revision: https://phabricator.freedesktop.org/D1610
-
Philip Withnall authored
This will shortly be used to implement secure random number generation. Differential Revision: https://phabricator.freedesktop.org/D1609
-
Philip Withnall authored
The SHA-1 and MD5 implementations in libnice are about to be removed, so stop testing them explicitly. In addition, rework the remaining test to use the stun_sha1() API which will remain. Differential Revision: https://phabricator.freedesktop.org/D1608
-
- 28 Mar, 2017 1 commit
-
-
Philip Withnall authored
There should never be a problem with alignment at runtime, since we’re casting the sockaddr to sockaddr_in or sockaddr_in6 based on its declared sa_family — anything declared as AF_INET6 should have been allocated as a sockaddr_in6, and hence have appropriate alignment (same for AF_INET). This fixes a compiler warning on ARM and other alignment-sensitive architectures. https://phabricator.freedesktop.org/T7718Signed-off-by:
Philip Withnall <withnall@endlessm.com> Reviewed-by:
Olivier Crête <olivier.crete@collabora.com> Differential Revision: https://phabricator.freedesktop.org/D1686
-