1. 27 May, 2016 3 commits
    • Olivier Crête's avatar
      agent: Restrict transitions to gathering · b72b9153
      Olivier Crête authored
      Only allow transitions to gathering from disconnected or
      failed states.
      b72b9153
    • Olivier Crête's avatar
      conncheck: fix TCP active relay handling · 059a0e33
      Olivier Crête authored
      TCP active relay candidates use UDP TURN for their underlying socket.
      Since 0a6c779f, socket->fileno of UDP TURN sockets is always NULL,
      which caused a wrong code path to be chosen in conn_check_send().
      
      We have to update the if-expression accordingly.
      
      Maniphest Tasks: T7442
      Differential Revision: https://phabricator.freedesktop.org/D1017
      059a0e33
    • Olivier Crête's avatar
      agent: ignore gathering failures on auto-generated IPs · fc4d3aab
      Olivier Crête authored
      Candidate gathering is stopped when discovery_add_local_host_candidate()
      returns HOST_CANDIDATE_CANT_CREATE_SOCKET. This may be too radical
      a measure when other local addresses can still be able to generate
      usable candidates.
      
      The issue was observed by a user who had an IPv6 address with tentative
      flag on one of the interfaces. That single failing address was causing
      the whole gathering process to end with no candidates found.
      
      Still, don't do this if nice_agent_add_local_address() has been called.
      In that case, the user really cares about the addresses and if there's
      any problem, the process should fail.
      
      https://phabricator.freedesktop.org/D1016
      fc4d3aab
  2. 26 May, 2016 16 commits
  3. 20 May, 2016 1 commit
  4. 04 Apr, 2016 5 commits
  5. 06 Mar, 2016 1 commit
  6. 05 Mar, 2016 1 commit
  7. 02 Mar, 2016 1 commit
    • Jakub Adam's avatar
      agent: fix relay candidate discovery on hosts having several IPs · ed75d55c
      Jakub Adam authored
      When a message is received from a TURN server and we manage to find a
      local relay candidate with matching stream and component IDs, we should
      also check whether the message came from the candidate's respective
      socket.
      
      We should do this because there might still be some pending TURN
      candidate discovery with the same server from a different local host IP
      and the message may be a response to our allocate request. If
      nice_udp_turn_socket_parse_recv_message() is passed such request, it can
      make some wrong assumptions and modify it like in the case of reliable
      UDP-TURN-OVER-TCP by removing (supposed) RFC4571 framing, which in turn
      causes the reply to be unrecognized and discarded.
      
      Because of this, any subsequent replies following the first successful
      allocate response from that server couldn't create any additional relay
      candidates.
      
      Maniphest Tasks: https://phabricator.freedesktop.org/T7336Reviewed-by: default avatarOlivier Crête <olivier.crete@collabora.com>
      Differential Revision: https://phabricator.freedesktop.org/D786
      ed75d55c
  8. 01 Mar, 2016 11 commits
  9. 18 Jan, 2016 1 commit