- 18 Aug, 2014 3 commits
-
-
Olivier Crête authored
The signal is only connected when setting an agent, if no agent has been set, there will be no signal.
-
Philip Withnall authored
ssize_t should definitely be signed, not unsigned.
-
Philip Withnall authored
As spotted by B Andrei on the mailing list.
-
- 14 Aug, 2014 1 commit
-
-
Philip Withnall authored
At that point, (len > 0), since there are conditions above handling the (len == 0) and (len < 0) cases, both of which break from the loop. Coverity issue: #29325
-
- 13 Aug, 2014 2 commits
-
-
Youness Alaoui authored
-
Youness Alaoui authored
-
- 12 Aug, 2014 1 commit
-
-
Olivier Crête authored
Otherwise, it claimed it was connected when the component was in the FAILED state, when it should really have gone to connecting.
-
- 11 Aug, 2014 2 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
- 08 Aug, 2014 2 commits
-
-
Philip Withnall authored
-
Youness Alaoui authored
Set candidate pairs from discovered peer-reflx tcp-passive candidates into DISCOVERED state so it doesn't fail if the other side doesn't reply to our binding request
-
- 31 Jul, 2014 1 commit
-
-
Youness Alaoui authored
The retransmissions would timeout after 600ms which caused the TCP connections to timeout before it's able to connect. TCP sockets need to timeout after 8 seconds instead.
-
- 25 Jul, 2014 3 commits
-
-
Olivier Crête authored
This reverts commit 18e5dff4.
-
Youness Alaoui authored
-
Youness Alaoui authored
The pseudo_tcp_socket_get_next_clock returns the next clock in terms of g_get_monotonic_clock / 1000, however, it gets cropped to guint32. When we try to find the interval, by substracting the current time as a guint64, it will return a negative value, which prevents an integer overflow by setting the timeout to 0. This causes the notify_clock timeout to be called all the time by the mainloop, taking 100% of CPU.
-
- 24 Jul, 2014 1 commit
-
-
Olivier Crête authored
This way all the debug can be controlled from one place. Also disable -Wsuggest-attribute=format with -Werror because gcc 4.8.3 erroneously suggested it.
-
- 23 Jul, 2014 6 commits
-
-
Olivier Crête authored
Also add one for pseudotcp-verbose
-
Olivier Crête authored
Send thing one line at a time, so no explicit \n Also make it possible to set a log handler explicitly
-
Youness Alaoui authored
The TURN CreatePermission is a list of multiple permissions but the timer is created and overwrites the old one, so some of them don't get triggered at the right time. This patch was suggested by Livio Madaro. We create a timer for the minimal amount of time, and trigger the retransmissions on the permissions that timed out, then reschedule for the next retransmissions.
-
Livio Madaro authored
-
Youness Alaoui authored
When calling component_emit_io_callback, the agent mutex will be unlocked before the callback is called, this can cause another thread to remove the stream and thus destroying the component. We must verify that the source was not destroyed after calling component_emit_io_callback and avoid accessing the component in that case. Bug report by Stephan Thamm in the mailing list.
-
Youness Alaoui authored
-
- 16 Jul, 2014 1 commit
-
-
Philip Withnall authored
Rather than assuming it is not available on Windows.
-
- 12 Jul, 2014 3 commits
-
-
Olivier Crête authored
-
Youness Alaoui authored
-
Olivier Crête authored
Otherwise, the caller gets a callback from an unexpected source.
-
- 07 Jul, 2014 14 commits
-
-
Philip Withnall authored
-
Philip Withnall authored
-
Philip Withnall authored
The old GetIpAddrTable() function only returned IPv4 addresses. In order to support IPv6 addresses, we need to use GetAdapterAddresses(), which is available from Windows XP or Server 2003 onwards.
-
Philip Withnall authored
Rather than using inet_pton(), which doesn’t support IPv6 link-local scope IDs, use getaddrinfo(). This is supported on all platforms (POSIX.1-2001, and Windows winsock).
-
Philip Withnall authored
inet_ntop() drops IPv6 link-local scope IDs on the floor, which means libnice doesn’t generate any IPv6 candidates for link-local connections, meaning that it will theoretically fail to negotiate a connection on an IPv6-only network where the two peers are local. Fix that by using getnameinfo() to convert sockaddrs to strings, which preserves the scope ID. There are no portability concerns — getnameinfo() is POSIX.1-2001, and isn’t used on Windows (although it is supported, surprisingly).
-
Olivier Crête authored
Otherwise we're never woken up when it's again possible to send
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Philip Withnall authored
If (agent->main_context == NULL) the sockets are created with a NULL main context, which they then try to ref. That does not end well.
-
Philip Withnall authored
We know the agent is a GObject — there is no need to check it at runtime. This also improves Tartan’s static analysis of signal connections.
-
Philip Withnall authored
Spotted by Tartan.
-
Philip Withnall authored
-
Philip Withnall authored
-