- 11 Jul, 2019 1 commit
-
-
Fabrice Bellet authored
The current valid pair nomination makes no effort to select pairs that could have some similarities across different components and different streams. This is normally not required by the RFC8445, but some well known applications will misbehave when the libnice agent is in this position to choose the nominated pairs (regular nomination mode, and controlling mode) and if it makes an unexpected choice from the peer point-of-view. This patch improves the stopping criterion and the selection of the preferred pair to nominate in that case. When no other pair has been nominated yet (across all streams), the previous stopping criterion still applies, and the best ranked pair of the checklist is selected. When a nominated pair exists from another component, we try to nominate a pair of the same kind (same local and remote addresses and same transport) if we have one, and possibly the best pair we have in the checklist, and else we look for a nominated pair from another stream.
-
- 04 Jul, 2019 24 commits
-
-
Fabrice Bellet authored
-
Fabrice Bellet authored
-
Fabrice Bellet authored
-
Fabrice Bellet authored
The source is also detached in socket_source_free()
-
Fabrice Bellet authored
This final idle timeout is renamed from the NICE_AGENT_MAX_TIMER_GRACE_PERIOD macro, and keeps its semantic. We also increase the default value of this timeout from 1 second to 5 seconds. This is useful for the sipe pidgin plugin that has to deal with SfB agents, that may take some time in controlling mode before choosing and testing the nominated pair
-
Fabrice Bellet authored
This patch fixes the priority assigned to a peer reflexive discovered local candidate, when the agent has the stun client role and receives an stun reply. This priority must be the value put in the stun request, ie the pair->rflx_priority from the parent pair. This ensures two similar ordered pairs, will generate discovered pairs ordered in the same way for the stun client, and also for the stun server on the other side. Without this identical ordered on both sides of the connections, the two agents may nominate a different pair with the aggresive nomination scenario, since both are valid. The other fix concerns the function that ensures local candidates priority uniqueness, that breaks the assumption that "two local candidates having the same priority should generate the same prflx_priority in the pairs they contribute". Respecting this assumption is important to stay coherent with the behavior of the other agent, that considers that two stun requests coming from the same peer-reflexive remote candidate will have the same remote priority (once a remote candidate is added to the component remote_candidates list, its priority is not supposed to change).
-
Fabrice Bellet authored
When replaying the incoming checks, we have to create the succeeded valid pair matching this tcp connection the same way we do it in conn_check_handle_inbound_stun().
-
Fabrice Bellet authored
These candidates type is updated from peer-reflexive, discovered during early incoming checks, to the type of the matching regularly transmitted candidate, so the previous sockptr value is no longer of interest here. The same socket is already associated to the initial local candidate anyway, source of the early discovery.
-
Fabrice Bellet authored
A socket to be removed may also come from a peer-reflexive remote candidate, and some cleanup also needs to be done in this case. This reference in a remote peer-reflexive tcp-active candidate caused a heap-use-after-free asan error in some custom debugging dump of the list of sockets of a component, after a read error in component_io_cb(): agent_recv_message_unlocked returned -1, errno (25) : Inappropriate ioctl for device
-
Fabrice Bellet authored
-
Fabrice Bellet authored
-
Fabrice Bellet authored
The candidate may be a newly discovered peer reflexive one, or a server reflexive initial candidate, where address and base address differ. Early incoming checks are received on the base address. These incoming checks may accumulate if remote credentials arrive with a delay.
-
Fabrice Bellet authored
-
Fabrice Bellet authored
In complement to the conncheck list, we dump the pair transport type, the socket type, and the incoming checks list.
-
Fabrice Bellet authored
-
Fabrice Bellet authored
This complete the similar debug trace when remote candidates are received, and help to debug our tests with the patched farstream library, where candidates and credentials are transmitted with a random delay.
-
Fabrice Bellet authored
This foundation update may be needed when a selected pair contains a remote candidate that has been found by an inbound stun request, but has not been received by nice_agent_set_remote_candidates()
-
Fabrice Bellet authored
-
Fabrice Bellet authored
-
Fabrice Bellet authored
This reverts commit ca47519f.
-
Fabrice Bellet authored
conn_check_prune_socket() on nsocket must be called before removing the candidate with this socket inside the loop, to prevent the use-after-free reported initially in issue #73. But commit 541801d4 introduced a regression during discovery when an udp turn over tcp socket is immediately closed by a HUP condition for example. In this case, discovery_prune_socket() is never called, because we don't have a candidate with this socket inside the loop. So the nsocket is freed by the final nice_component_detach_socket() but is still used by the discovery timer callback. This commit moves the discovery_prune_socket() and conn_check_prune_socket() actions before the loop instead of after, or inside. Closes #73
-
Fabrice Bellet authored
-
Fabrice Bellet authored
The patch makes the agent alive at least until the last callback of the removal of turn refreshes when a stream is deleted from the agent. Closes #84
-
Fabrice Bellet authored
The base64 decoded username and password strings given to stun_usage_turn_create() should not freed immediately, since they remain used when handling the following related inbound stun replies.
-
- 03 Jul, 2019 1 commit
-
-
Olivier Crête authored
The automake generated ones are a little funky, so the meson one have to also be to not break API...
-
- 02 Jul, 2019 1 commit
-
-
Olivier Crête authored
This API makes it possible to get an array of all of the sockets used by a specific component, this is useful to set options on the socket. Also bump GLib requirement to 2.54, which is the version in RHEL 7
-
- 27 Jun, 2019 8 commits
-
-
Fabrice Bellet authored
-
Stefan Becker authored
By default libnice now ignores network interfaces from virtual machines and containers, i.e. names that start with "docker", "veth", "virbr" and "vnet". If you want to disable this feature override the default with ./configure --without-ignored-network-interface-prefix ... ./configure --with-ignored-network-interface-prefix= ... meson setup -D ignored-network-interface-prefix= ... meson setup -D ignored-network-interface-prefix=[] ...
-
Stefan Becker authored
This fixes commit b4abda09 --without-XXX sets $withval to "no", hence we must check for this special value instead of ignoring network interfaces that start with "no".
-
Stefan Becker authored
The parameter for the ignored network interface prefix build option accepts a comma-separated string now. This list will be converted to a comma-separated list of string literals for the C code. Disable the feature: ./configure ... ./configure --with-ignored-network-interface-prefix= ... meson setup -D ignored-network-interface-prefix= ... meson setup -D ignored-network-interface-prefix=[] ... Ignore interfaces whose names start with "virbr": ./configure --with-ignored-network-interface-prefix=virbr ... meson setup -D ignored-network-interface-prefix=virbr ... Ignore interfaces whose names start with "virbr" or "veth": ./configure --with-ignored-network-interface-prefix=virbr,veth ... meson setup -D ignored-network-interface-prefix=virbr,veth ...
-
Stefan Becker authored
Improve on commit b4abda09 Instead of checking one prefix, check against a list of prefixes. This allows libnice to be configured to ignore interfaces from virtual machines and containers.
-
Stefan Becker authored
Check for IFF_UP and IFF_RUNNING flags on the interface.
-
Stefan Becker authored
This fixes commit 9afd0c8b
-
Stefan Becker authored
Update nice_interfaces_is_private_ip() to handle IPv6 too: - unique local address block: fc00::/7 - link-local address block: fe80::/10
-
- 26 Jun, 2019 2 commits
-
-
Stefan Becker authored
This fixes commit b4abda09 Copy the implementation to the !HAVE_GETIFADDRS branch too.
-
Stefan Becker authored
Clone implementation from HAVE_GETIFADDRS branch to !HAVE_GETIFADDRS branch of nice_interfaces_get_local_ips()
-
- 05 Jun, 2019 2 commits
-
-
alex authored
-
alex authored
Fix regression introduced by https://gitlab.freedesktop.org/libnice/libnice/commit/da41258a21102f63ec5d5b2dc20d303f772eb195. Fix #64.
-
- 29 May, 2019 1 commit
-
-
Jakub Adam authored
Code comment mentions peer reflexive candidate pair should be selected only in the case of TCP local candidates, but it was done in all cases.
-