Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
libnice
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
libnice
Commits
f482a02c
Commit
f482a02c
authored
Jun 12, 2019
by
Fabrice Bellet
Committed by
Olivier Crête
Jul 04, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
socket: fix a heap use-after-free on the send queue
parent
a383faa4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
6 deletions
+6
-6
socket/socket.c
socket/socket.c
+6
-6
No files found.
socket/socket.c
View file @
f482a02c
...
@@ -358,12 +358,6 @@ void nice_socket_queue_send_with_callback (GQueue *send_queue,
...
@@ -358,12 +358,6 @@ void nice_socket_queue_send_with_callback (GQueue *send_queue,
else
else
g_queue_push_tail
(
send_queue
,
tbs
);
g_queue_push_tail
(
send_queue
,
tbs
);
if
(
io_source
&&
gsock
&&
context
&&
cb
&&
*
io_source
==
NULL
)
{
*
io_source
=
g_socket_create_source
(
gsock
,
G_IO_OUT
,
NULL
);
g_source_set_callback
(
*
io_source
,
(
GSourceFunc
)
G_CALLBACK
(
cb
),
user_data
,
NULL
);
g_source_attach
(
*
io_source
,
context
);
}
/* Move the data into the buffer. */
/* Move the data into the buffer. */
for
(
j
=
0
;
for
(
j
=
0
;
(
message
->
n_buffers
>=
0
&&
j
<
(
guint
)
message
->
n_buffers
)
||
(
message
->
n_buffers
>=
0
&&
j
<
(
guint
)
message
->
n_buffers
)
||
...
@@ -386,6 +380,12 @@ void nice_socket_queue_send_with_callback (GQueue *send_queue,
...
@@ -386,6 +380,12 @@ void nice_socket_queue_send_with_callback (GQueue *send_queue,
else
else
message_offset
=
0
;
message_offset
=
0
;
}
}
if
(
io_source
&&
gsock
&&
context
&&
cb
&&
*
io_source
==
NULL
)
{
*
io_source
=
g_socket_create_source
(
gsock
,
G_IO_OUT
,
NULL
);
g_source_set_callback
(
*
io_source
,
(
GSourceFunc
)
G_CALLBACK
(
cb
),
user_data
,
NULL
);
g_source_attach
(
*
io_source
,
context
);
}
}
}
void
nice_socket_flush_send_queue
(
NiceSocket
*
base_socket
,
GQueue
*
send_queue
)
void
nice_socket_flush_send_queue
(
NiceSocket
*
base_socket
,
GQueue
*
send_queue
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment