Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
libnice
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
libnice
Commits
bf77d088
Commit
bf77d088
authored
Dec 27, 2018
by
Olivier Crête
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix little bugs found by clang-analyzer
parent
928d21e9
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
7 additions
and
8 deletions
+7
-8
agent/agent.c
agent/agent.c
+2
-0
agent/conncheck.c
agent/conncheck.c
+2
-2
stun/tests/test-format.c
stun/tests/test-format.c
+1
-1
stun/usages/bind.c
stun/usages/bind.c
+2
-0
tests/test-gstreamer.c
tests/test-gstreamer.c
+0
-5
No files found.
agent/agent.c
View file @
bf77d088
...
...
@@ -5849,6 +5849,8 @@ nice_agent_set_software (NiceAgent *agent, const gchar *software)
if
(
software
)
agent
->
software_attribute
=
g_strdup_printf
(
"%s/%s"
,
software
,
PACKAGE_STRING
);
else
agent
->
software_attribute
=
NULL
;
nice_agent_reset_all_stun_agents
(
agent
,
TRUE
);
...
...
agent/conncheck.c
View file @
bf77d088
...
...
@@ -3852,7 +3852,7 @@ static bool conncheck_stun_validater (StunAgent *agent,
ufrag
=
NULL
;
if
(
cand
->
username
)
ufrag
=
cand
->
username
;
else
if
(
data
->
stream
)
else
ufrag
=
data
->
stream
->
local_ufrag
;
ufrag_len
=
ufrag
?
strlen
(
ufrag
)
:
0
;
...
...
@@ -3873,7 +3873,7 @@ static bool conncheck_stun_validater (StunAgent *agent,
if
(
cand
->
password
)
pass
=
cand
->
password
;
else
if
(
data
->
stream
->
local_password
[
0
])
else
if
(
data
->
stream
&&
data
->
stream
->
local_password
[
0
])
pass
=
data
->
stream
->
local_password
;
if
(
pass
)
{
...
...
stun/tests/test-format.c
View file @
bf77d088
...
...
@@ -251,7 +251,7 @@ int main (void)
if
(
stun_message_append_xor_addr
(
&
msg
,
0xffff
,
&
addr
.
storage
,
sizeof
(
addr
))
!=
STUN_MESSAGE_RETURN_NOT_ENOUGH_SPACE
)
fatal
(
"Address overflow test failed"
);
len
=
sizeof
(
msg
);
if
(
stun_agent_finish_message
(
&
agent
,
&
msg
,
NULL
,
0
)
!=
0
)
fatal
(
"Fingerprint overflow test failed"
);
if
(
stun_agent_finish_message
(
&
agent
,
&
msg
,
pwd
,
strlen
((
char
*
)
pwd
))
!=
0
)
...
...
stun/usages/bind.c
View file @
bf77d088
...
...
@@ -483,6 +483,8 @@ StunUsageBindReturn stun_usage_bind_run (const struct sockaddr *srv,
socklen_t
alternate_server_len
=
sizeof
(
alternate_server
);
StunUsageBindReturn
bind_ret
;
trans
.
fd
=
-
1
;
stun_agent_init
(
&
agent
,
STUN_ALL_KNOWN_ATTRIBUTES
,
STUN_COMPATIBILITY_RFC3489
,
0
);
...
...
tests/test-gstreamer.c
View file @
bf77d088
...
...
@@ -105,7 +105,6 @@ create_buffer_list (void)
GstBufferList
*
list
;
GstBuffer
*
rtp_buffer
;
GstBuffer
*
data_buffer
;
gint
total_size
=
0
;
list
=
gst_buffer_list_new
();
...
...
@@ -122,8 +121,6 @@ create_buffer_list (void)
/* Create a new group to hold the rtp header and the payload */
gst_buffer_list_add
(
list
,
gst_buffer_append
(
rtp_buffer
,
data_buffer
));
total_size
+=
gst_buffer_get_size
(
rtp_buffer
);
/*** Second group, i.e. second packet. ***/
/* Create the RTP header buffer */
...
...
@@ -137,8 +134,6 @@ create_buffer_list (void)
/* Create a new group to hold the rtp header and the payload */
gst_buffer_list_add
(
list
,
gst_buffer_append
(
rtp_buffer
,
data_buffer
));
total_size
+=
gst_buffer_get_size
(
rtp_buffer
);
/* Calculate the size of the data */
data_size
=
2
*
RTP_HEADER_SIZE
+
2
*
RTP_PAYLOAD_SIZE
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment