Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
libnice
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
libnice
Commits
a2e13124
Commit
a2e13124
authored
Jan 31, 2014
by
Philip Withnall
Committed by
Olivier Crête
Feb 24, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
agent: Add nice_input_message_iter_compare()
Use it instead of memcmp() to avoid comparing padding bytes.
parent
b93ecef2
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
2 deletions
+24
-2
agent/agent-priv.h
agent/agent-priv.h
+3
-0
agent/agent.c
agent/agent.c
+21
-2
No files found.
agent/agent-priv.h
View file @
a2e13124
...
...
@@ -82,6 +82,9 @@ nice_input_message_iter_is_at_end (NiceInputMessageIter *iter,
NiceInputMessage
*
messages
,
guint
n_messages
);
guint
nice_input_message_iter_get_n_valid_messages
(
NiceInputMessageIter
*
iter
);
gboolean
nice_input_message_iter_compare
(
const
NiceInputMessageIter
*
a
,
const
NiceInputMessageIter
*
b
);
#include "socket.h"
...
...
agent/agent.c
View file @
a2e13124
...
...
@@ -2970,6 +2970,25 @@ nice_input_message_iter_get_n_valid_messages (NiceInputMessageIter *iter)
return
iter
->
message
+
1
;
}
/**
* nice_input_message_iter_compare:
* @a: a #NiceInputMessageIter
* @b: another #NiceInputMessageIter
*
* Compare two #NiceInputMessageIters for equality, returning %TRUE if they
* point to the same place in the receive message array.
*
* Returns: %TRUE if the iters match, %FALSE otherwise
*
* Since: 0.1.5
*/
gboolean
nice_input_message_iter_compare
(
const
NiceInputMessageIter
*
a
,
const
NiceInputMessageIter
*
b
)
{
return
(
a
->
message
==
b
->
message
&&
a
->
buffer
==
b
->
buffer
&&
a
->
offset
==
b
->
offset
);
}
/* Will fill up @messages from the first free byte onwards (as determined using
* @iter). This may be used in reliable or non-reliable mode; in non-reliable
* mode it will always increment the message index after each buffer is
...
...
@@ -3182,8 +3201,8 @@ nice_agent_recv_messages_blocking_or_nonblocking (NiceAgent *agent,
component
->
recv_messages
,
component
->
n_recv_messages
);
error_reported
=
(
child_error
!=
NULL
);
all_sockets_would_block
=
(
!
blocking
&&
memcmp
(
&
prev_recv_messages_iter
,
&
component
->
recv_messages_iter
,
sizeof
(
NiceInputMessageIter
))
==
0
);
nice_input_message_iter_compare
(
&
prev_
recv_messages_iter
,
&
component
->
recv_messages_iter
)
);
}
n_valid_messages
=
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment