Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
libnice
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
libnice
Commits
6c893546
Commit
6c893546
authored
Apr 15, 2014
by
Olivier Crête
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
component: Remove return value from *_restart() functions, they can't fail
parent
f5373319
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
10 additions
and
16 deletions
+10
-16
agent/agent.c
agent/agent.c
+3
-4
agent/component.c
agent/component.c
+1
-3
agent/component.h
agent/component.h
+1
-1
agent/stream.c
agent/stream.c
+4
-7
agent/stream.h
agent/stream.h
+1
-1
No files found.
agent/agent.c
View file @
6c893546
...
...
@@ -3695,7 +3695,6 @@ nice_agent_restart (
NiceAgent
*
agent
)
{
GSList
*
i
;
gboolean
res
=
TRUE
;
agent_lock
();
...
...
@@ -3705,16 +3704,16 @@ nice_agent_restart (
/* step: regenerate tie-breaker value */
priv_generate_tie_breaker
(
agent
);
for
(
i
=
agent
->
streams
;
i
&&
res
;
i
=
i
->
next
)
{
for
(
i
=
agent
->
streams
;
i
;
i
=
i
->
next
)
{
Stream
*
stream
=
i
->
data
;
/* step: reset local credentials for the stream and
* clean up the list of remote candidates */
res
=
stream_restart
(
stream
,
agent
->
rng
);
stream_restart
(
stream
,
agent
->
rng
);
}
agent_unlock_and_emit
(
agent
);
return
res
;
return
TRUE
;
}
...
...
agent/component.c
View file @
6c893546
...
...
@@ -276,7 +276,7 @@ component_find_pair (Component *cmp, NiceAgent *agent, const gchar *lfoundation,
* Resets the component state to that of a ICE restarted
* session.
*/
gboolean
void
component_restart
(
Component
*
cmp
)
{
GSList
*
i
;
...
...
@@ -307,8 +307,6 @@ component_restart (Component *cmp)
cmp
->
incoming_checks
=
NULL
;
/* note: component state managed by agent */
return
TRUE
;
}
/*
...
...
agent/component.h
View file @
6c893546
...
...
@@ -214,7 +214,7 @@ component_free (Component *cmp);
gboolean
component_find_pair
(
Component
*
cmp
,
NiceAgent
*
agent
,
const
gchar
*
lfoundation
,
const
gchar
*
rfoundation
,
CandidatePair
*
pair
);
gboolean
void
component_restart
(
Component
*
cmp
);
void
...
...
agent/stream.c
View file @
6c893546
...
...
@@ -132,22 +132,19 @@ void stream_initialize_credentials (Stream *stream, NiceRNG *rng)
* Resets the stream state to that of a ICE restarted
* session.
*/
gboolean
void
stream_restart
(
Stream
*
stream
,
NiceRNG
*
rng
)
{
GSList
*
i
;
gboolean
res
=
TRUE
;
stream
->
initial_binding_request_received
=
FALSE
;
stream_initialize_credentials
(
stream
,
rng
);
for
(
i
=
stream
->
components
;
i
&&
res
;
i
=
i
->
next
)
{
for
(
i
=
stream
->
components
;
i
;
i
=
i
->
next
)
{
Component
*
component
=
i
->
data
;
res
=
component_restart
(
component
);
component_restart
(
component
);
}
return
res
;
}
agent/stream.h
View file @
6c893546
...
...
@@ -92,7 +92,7 @@ stream_find_component_by_id (const Stream *stream, guint id);
void
stream_initialize_credentials
(
Stream
*
stream
,
NiceRNG
*
rng
);
gboolean
void
stream_restart
(
Stream
*
stream
,
NiceRNG
*
rng
);
G_END_DECLS
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment