Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
A
Actor Framework
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
cpp-libs
Actor Framework
Commits
fa64df9d
Commit
fa64df9d
authored
Nov 19, 2020
by
Dominik Charousset
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix unsafe use of strncmp
parent
91148be1
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
10 deletions
+12
-10
libcaf_core/src/string_view.cpp
libcaf_core/src/string_view.cpp
+12
-10
No files found.
libcaf_core/src/string_view.cpp
View file @
fa64df9d
...
@@ -102,16 +102,18 @@ string_view string_view::substr(size_type pos, size_type n) const noexcept {
...
@@ -102,16 +102,18 @@ string_view string_view::substr(size_type pos, size_type n) const noexcept {
}
}
int
string_view
::
compare
(
string_view
str
)
const
noexcept
{
int
string_view
::
compare
(
string_view
str
)
const
noexcept
{
auto
s0
=
size
();
// TODO: use lexicographical_compare_three_way when switching to C++20
auto
s1
=
str
.
size
();
auto
i0
=
begin
();
auto
fallback
=
[](
int
x
,
int
y
)
{
auto
e0
=
end
();
return
x
==
0
?
y
:
x
;
auto
i1
=
str
.
begin
();
};
auto
e1
=
str
.
end
();
if
(
s0
==
s1
)
while
(
i0
!=
e0
&&
i1
!=
e1
)
return
strncmp
(
data
(),
str
.
data
(),
s0
);
if
(
auto
diff
=
*
i0
++
-
*
i1
++
;
diff
!=
0
)
else
if
(
s0
<
s1
)
return
diff
;
return
fallback
(
strncmp
(
data
(),
str
.
data
(),
s0
),
-
1
);
if
(
i0
==
e0
)
return
fallback
(
strncmp
(
data
(),
str
.
data
(),
s1
),
1
);
return
i1
!=
e1
?
-
1
:
0
;
else
return
i1
==
e1
?
1
:
0
;
}
}
int
string_view
::
compare
(
size_type
pos1
,
size_type
n1
,
int
string_view
::
compare
(
size_type
pos1
,
size_type
n1
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment