Commit f62b9932 authored by Dominik Charousset's avatar Dominik Charousset

Integrate review feedback

parent 528e7e26
......@@ -345,7 +345,7 @@ public:
return virt_field_t<field_type, Set>{name, std::move(set)};
} else {
static_assert(std::is_same<setter_result, void>::value,
"setter must return caf::error, bool or void");
"a setter must return caf::error, bool or void");
auto set_fun = [f{std::move(set)}](field_type&& val) {
f(std::move(val));
return true;
......@@ -367,7 +367,7 @@ public:
std::move(set)};
} else {
static_assert(std::is_same<setter_result, void>::value,
"setter must return caf::error, bool or void");
"a setter must return caf::error, bool or void");
auto set_fun = [f{std::move(set)}](field_type&& val) {
f(std::move(val));
return true;
......
......@@ -661,7 +661,7 @@ end object)_";
auto x = line{{10, 10, 10}, {20, 20, 20}};
auto get = [&x] { return x; };
auto set = [](line) { return error{sec::runtime_error}; };
THEN("the inspector overrides the state using the setter") {
THEN("the inspection fails") {
CHECK(!f.apply(get, set));
CHECK_EQ(f.get_error(), sec::runtime_error);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment