Commit db0007bb authored by Dominik Charousset's avatar Dominik Charousset

Add missing compare overload

parent 23cb4188
......@@ -6,6 +6,12 @@ is based on [Keep a Changelog](https://keepachangelog.com).
## [Unreleased]
### Added
- The class `caf::telemetry::label` now has a new `compare` overload that
accepts a `caf::telemetry::label_view` to make the interface of the both
classes symmetrical.
### Changed
- When using CAF to parse CLI arguments, the output of `--help` now includes all
......
......@@ -53,6 +53,8 @@ public:
// -- comparison -------------------------------------------------------------
int compare(const label_view& x) const noexcept;
int compare(const label& x) const noexcept;
private:
......
......@@ -25,8 +25,14 @@ void label::value(std::string_view new_value) {
str_.insert(str_.end(), new_value.begin(), new_value.end());
}
int label::compare(const label_view& x) const noexcept {
auto cmp1 = name().compare(x.name());
return cmp1 != 0 ? cmp1 : value().compare(x.value());
}
int label::compare(const label& x) const noexcept {
return str_.compare(x.str());
auto cmp1 = name().compare(x.name());
return cmp1 != 0 ? cmp1 : value().compare(x.value());
}
std::string to_string(const label& x) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment