Unverified Commit c64964ea authored by Samir Halilčević's avatar Samir Halilčević Committed by GitHub

Integrate review feedback

Co-authored-by: default avatarDominik Charousset <dominik@charousset.de>
parent 8f40da46
...@@ -144,7 +144,7 @@ private: ...@@ -144,7 +144,7 @@ private:
size_t max_consecutive_reads_; size_t max_consecutive_reads_;
}; };
/// Specializes @ref connection_factory for custom upper layer implementation. /// Specializes @ref connection_factory for custom upper layer implementations.
template <class Transport, class MakeApp> template <class Transport, class MakeApp>
class ws_simple_conn_factory class ws_simple_conn_factory
: public connection_factory<typename Transport::connection_handle> { : public connection_factory<typename Transport::connection_handle> {
...@@ -164,8 +164,7 @@ public: ...@@ -164,8 +164,7 @@ public:
auto transport = Transport::make(std::move(conn), std::move(ws)); auto transport = Transport::make(std::move(conn), std::move(ws));
transport->max_consecutive_reads(max_consecutive_reads_); transport->max_consecutive_reads(max_consecutive_reads_);
transport->active_policy().accept(); transport->active_policy().accept();
auto mgr = net::socket_manager::make(mpx, std::move(transport)); return net::socket_manager::make(mpx, std::move(transport));
return mgr;
} }
private: private:
......
...@@ -113,7 +113,7 @@ int caf_main(caf::actor_system& sys, const config& cfg) { ...@@ -113,7 +113,7 @@ int caf_main(caf::actor_system& sys, const config& cfg) {
// Ignore all header fields and accept the connection. // Ignore all header fields and accept the connection.
acc.accept(); acc.accept();
}) })
// When started, run our worker actor to handle incoming connections. // Create instances of our app to handle incoming connections.
.start([] { return web_socket_app::make(); }); .start([] { return web_socket_app::make(); });
// Report any error to the user. // Report any error to the user.
if (!server) { if (!server) {
...@@ -121,6 +121,7 @@ int caf_main(caf::actor_system& sys, const config& cfg) { ...@@ -121,6 +121,7 @@ int caf_main(caf::actor_system& sys, const config& cfg) {
<< to_string(server.error()) << '\n'; << to_string(server.error()) << '\n';
return EXIT_FAILURE; return EXIT_FAILURE;
} }
// Wait until the server shuts down.
while (server->valid()) { while (server->valid()) {
std::this_thread::sleep_for(1s); std::this_thread::sleep_for(1s);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment