Commit 8471f13f authored by Dominik Charousset's avatar Dominik Charousset

Integrate review feedback

parent e22067f8
......@@ -298,8 +298,8 @@ public:
/// Send a `node_down_msg` to `observer` if this system loses connection to
/// `node`.
/// @note Calling this function *n* times causes the system to send
/// `node_down_msg` *n* times. In order to not receive the messages, the
/// observer must call `demonitor` *n* times.
/// `node_down_msg` *n* times to the observer. In order to not receive
/// the messages, the observer must call `demonitor` *n* times.
void monitor(const node_id& node, const actor_addr& observer);
/// Removes `observer` from the list of actors that receive a `node_down_msg`
......
......@@ -623,8 +623,8 @@ void basp_broker::set_context(connection_handle hdl) {
void basp_broker::connection_cleanup(connection_handle hdl, sec code) {
CAF_LOG_TRACE(CAF_ARG(hdl) << CAF_ARG(code));
// Remove handle from the routing table and clean up any node-specific state
// we might still have.
// Remove handle from the routing table, notify all observers, and clean up
// any node-specific state we might still have.
if (auto nid = instance.tbl().erase_direct(hdl)) {
emit_node_down_msg(nid, code);
purge_state(nid);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment