Commit 7e6f2824 authored by Dominik Charousset's avatar Dominik Charousset

Fix rendering of histograms

parent ec3b75a1
......@@ -299,15 +299,14 @@ void prometheus::append_histogram(const metric_family* family,
set_current_family(family, "histogram");
auto& vm = i->second;
auto buckets = val->buckets();
size_t index = 0;
for (; index < buckets.size() - 1; ++index) {
append(buf_, vm[index], buckets[index].count.value(), ' ',
ms_timestamp{now_}, '\n');
auto acc = ValueType{0};
auto index = size_t{0};
for (; index < buckets.size(); ++index) {
acc += buckets[index].count.value();
append(buf_, vm[index], acc, ' ', ms_timestamp{now_}, '\n');
}
auto count = buckets[index].count.value();
append(buf_, vm[index], count, ' ', ms_timestamp{now_}, '\n');
append(buf_, vm[++index], val->sum(), ' ', ms_timestamp{now_}, '\n');
append(buf_, vm[++index], count, ' ', ms_timestamp{now_}, '\n');
append(buf_, vm[index++], val->sum(), ' ', ms_timestamp{now_}, '\n');
append(buf_, vm[index++], acc, ' ', ms_timestamp{now_}, '\n');
}
} // namespace caf::telemetry::collector
......@@ -73,9 +73,9 @@ other_value_seconds_total{x="true"} 31337 42000
some_request_duration_seconds_bucket{x="get",le="1"} 0 42000
some_request_duration_seconds_bucket{x="get",le="2"} 0 42000
some_request_duration_seconds_bucket{x="get",le="4"} 2 42000
some_request_duration_seconds_bucket{x="get",le="+Inf"} 1 42000
some_request_duration_seconds_bucket{x="get",le="+Inf"} 3 42000
some_request_duration_seconds_sum{x="get"} 14 42000
some_request_duration_seconds_count{x="get"} 1 42000
some_request_duration_seconds_count{x="get"} 3 42000
)"_sv);
CAF_MESSAGE("multiple runs generate the same output");
std::string res1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment