Commit 7a8cac4b authored by Jakob Otto's avatar Jakob Otto

Address review feedback

parent 819d54e8
...@@ -99,14 +99,13 @@ public: ...@@ -99,14 +99,13 @@ public:
bool handle_write_event(endpoint_manager& manager) override { bool handle_write_event(endpoint_manager& manager) override {
CAF_LOG_TRACE(CAF_ARG2("handle", this->handle_.id) CAF_LOG_TRACE(CAF_ARG2("handle", this->handle_.id)
<< CAF_ARG2("queue-size", this->packet_queue_.size())); << CAF_ARG2("queue-size", packet_queue_.size()));
auto get_messages = [&] { auto get_message = [&] {
for (auto msg = manager.next_message(); msg != nullptr; if (auto msg = manager.next_message())
msg = manager.next_message())
this->next_layer_.write_message(*this, std::move(msg)); this->next_layer_.write_message(*this, std::move(msg));
return !packet_queue_.empty(); return !packet_queue_.empty();
}; };
while (write_some() && get_messages()) while (write_some() && get_message())
; // nop ; // nop
return !packet_queue_.empty(); return !packet_queue_.empty();
} }
......
...@@ -105,15 +105,14 @@ public: ...@@ -105,15 +105,14 @@ public:
} }
bool handle_write_event(endpoint_manager& manager) override { bool handle_write_event(endpoint_manager& manager) override {
CAF_LOG_TRACE(CAF_ARG2("handle", this->handle().id) CAF_LOG_TRACE(CAF_ARG2("handle", this->handle_.id)
<< CAF_ARG2("queue-size", write_queue_.size())); << CAF_ARG2("queue-size", write_queue_.size()));
auto get_messages = [&] { auto get_message = [&] {
for (auto msg = manager.next_message(); msg != nullptr; if (auto msg = manager.next_message())
msg = manager.next_message())
this->next_layer_.write_message(*this, std::move(msg)); this->next_layer_.write_message(*this, std::move(msg));
return !write_queue_.empty(); return !write_queue_.empty();
}; };
while (write_some() && get_messages()) while (write_some() && get_message())
; // nop ; // nop
return !write_queue_.empty(); return !write_queue_.empty();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment