Unverified Commit 7081bef0 authored by Dominik Charousset's avatar Dominik Charousset Committed by GitHub

Merge pull request #1512

Some clang tidy fixes
parents b618678f bce338ea
---
Checks: '-*,bugprone-*'
Checks: '-*,bugprone-*,-bugprone-easily-swappable-parameters,-bugprone-macro-parentheses'
WarningsAsErrors: ''
HeaderFilterRegex: '/caf/'
AnalyzeTemporaryDtors: false
......
......@@ -628,7 +628,7 @@ struct variant_inspector_traits<config_value> {
template <class U>
static void assign(value_type& x, U&& value) {
x = std::move(value);
x = std::forward<U>(value);
}
template <class F>
......
......@@ -232,7 +232,7 @@ private:
void add(Input&& x) {
using input_t = std::decay_t<Input>;
static_assert(is_observable_v<input_t>);
inputs_.emplace_back(std::move(x).as_observable());
inputs_.emplace_back(std::forward<Input>(x).as_observable());
}
std::vector<input_type> inputs_;
......
......@@ -201,7 +201,7 @@ private:
behavior make_behavior(F&& f, OnError&& g) {
using namespace detail;
using helper_type = select_all_helper_t<decay_t<F>>;
helper_type helper{ids_.size(), pending_timeouts_, std::move(f)};
helper_type helper{ids_.size(), pending_timeouts_, std::forward<F>(f)};
auto pending = helper.pending;
auto error_handler = [pending{std::move(pending)},
timeouts{pending_timeouts_},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment