Commit 25a601e1 authored by Dominik Charousset's avatar Dominik Charousset

Integrate review feedback

parent 9c7b9ab7
......@@ -508,7 +508,7 @@ struct select_config_value_access<T, select_config_value_hint::is_list> {
};
};
/// Catches all non-specialized list types.
/// Catches all non-specialized map types.
template <class T>
struct select_config_value_access<T, select_config_value_hint::is_map> {
struct type {
......
......@@ -36,7 +36,7 @@ public:
/// Checks whether `x` matches the type of this field.
virtual bool type_check(const config_value& x) const noexcept = 0;
/// Returns whether this field in `object` .
/// Returns whether this field in `object` contains valid data.
virtual bool valid(const Object& object) const noexcept = 0;
/// Returns whether this field has a default value.
......@@ -50,7 +50,7 @@ public:
// -- modifiers --------------------------------------------------------------
/// Sets this field in `object` to `x`.`
/// Sets this field in `object` to `x`.
/// @pre `can_set(x)`
virtual void set(Object& object, const config_value& x) const = 0;
......
......@@ -94,7 +94,7 @@ void store_timespan(void* ptr, const config_value& x) {
template <uint64_t Denominator>
config_value get_timespan(const void* ptr) {
auto ival = static_cast<int64_t>(*static_cast<const size_t*>(ptr));
timespan val{ival * 1000};
timespan val{ival * Denominator};
return config_value{val};
}
......
......@@ -215,8 +215,8 @@ CAF_TEST(oject access from dictionary - foobar) {
auto fb = get<foobar>(x, "my-value");
CAF_CHECK_EQUAL(fb.foo, 123);
CAF_CHECK_EQUAL(fb.bar, "hello");
CAF_MESSAGE("with foo member");
}
CAF_MESSAGE("with foo member");
put(x, "my-value.foo", 42);
{
CAF_REQUIRE(holds_alternative<foobar>(x, "my-value"));
......@@ -224,7 +224,6 @@ CAF_TEST(oject access from dictionary - foobar) {
auto fb = get<foobar>(x, "my-value");
CAF_CHECK_EQUAL(fb.foo, 42);
CAF_CHECK_EQUAL(fb.bar, "hello");
CAF_MESSAGE("with foo member");
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment